Teradata / covalent

Teradata UI Platform built on Angular Material
https://teradata.github.io/covalent/
MIT License
2.23k stars 358 forks source link

Editor is not shown in Electron #1620

Closed Stevertus closed 2 years ago

Stevertus commented 6 years ago

I had the same error as here: https://github.com/Teradata/covalent-code-editor/issues/22 I followed the instructions and the error is gone, however the editor is still not displayed.

<td-code-editor _ngcontent-c1="" automaticlayout="" id="editWindow" _nghost-c4="" ng-reflect-language="mcscript" ng-reflect-theme="mcfunction" ng-reflect-automatic-layout="" class="ng-untouched ng-valid ng-dirty" style="display: block;" ng-reflect-model="">
<div _ngcontent-c4="" class="editorContainer">
<webview nodeintegration="true" disablewebsecurity="true" src="data:text/html;base64,<!DOCTYPE html>
            <html style="height:100%">
            <head>
                <meta http-equiv="X-UA-Compatible" content="IE=edge" />
                <meta http-equiv="Content-Type" content="text/html;charset=utf-8" >
                <link rel="stylesheet" data-name="vs/editor/editor.main"
                    href="file:///assets/monaco/vs/editor/editor.main.css">
            </head>
            <body style="height:100%;width: 100%;margin: 0;padding: 0;overflow: hidden;">
            <div id="editorInnerContainer0" style="width:100%;height:100%;width:100%;height:100%;border:1px solid grey;"></div>
            <script>
                // Get the ipcRenderer of electron for communication
                const {ipcRenderer} = require('electron');
            </script>
            <script src="file:///assets/monaco/vs/loader.js"></script>
            <script>
                var editor;
                var theme = 'mcfunction';
                var value = '';
                require.config({
                    baseUrl: 'C:/webdev/angular 4/mcsEditor/assets/monaco'
                });
                self.module = undefined;
                self.process.browser = true;
                require(['vs/editor/editor.main'], function() {
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: value,
                        language: 'mcscript',
                        theme: 'mcfunction',
                    }, {}));
                    editor.getModel().onDidChangeContent( (e)=> {
                        ipcRenderer.sendToHost("onEditorContentChange", editor.getValue());
                    });
                    ipcRenderer.sendToHost("onEditorInitialized", '');
                });
                // return back the value in the editor to the mainview
                ipcRenderer.on('getEditorContent', function(){
                    ipcRenderer.sendToHost("editorContent", editor.getValue());
                });
                // set the value of the editor from what was sent from the mainview
                ipcRenderer.on('setEditorContent', function(event, data){
                    value = data;
                    editor.setValue(data);
                });
                // set the style of the editor container div
                ipcRenderer.on('setEditorStyle', function(event, data){
                    var editorDiv = document.getElementById('editorInnerContainer0');
                    editorDiv.style = data.style;
                    var currentValue = editor.getValue();
                    editor.dispose();
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: currentValue,
                        language: data.language,
                        theme: data.theme,
                    }, {}));
                });
                // set the options of the editor from what was sent from the mainview
                ipcRenderer.on('setEditorOptions', function(event, data){
                    editor.updateOptions(data);
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                });
                // set the language of the editor from what was sent from the mainview
                ipcRenderer.on('setLanguage', function(event, data){
                    var currentValue = editor.getValue();
                    editor.dispose();
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: currentValue,
                        language: data,
                        theme: theme,
                    }, {}));
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                    ipcRenderer.sendToHost("onEditorLanguageChanged", '');
                });
                // register a new language with editor
                ipcRenderer.on('registerLanguage', function(event, data){
                    var currentValue = editor.getValue();
                    editor.dispose();
                    for (var i = 0; i < data.completionItemProvider.length; i++) {
                        var provider = data.completionItemProvider[i];
                        provider.kind = eval(provider.kind);
                    }
                    for (var i = 0; i < data.monarchTokensProvider.length; i++) {
                        var monarchTokens = data.monarchTokensProvider[i];
                        monarchTokens[0] = eval(monarchTokens[0]);
                    }
                    monaco.languages.register({ id: data.id });
                    monaco.languages.setMonarchTokensProvider(data.id, {
                        tokenizer: {
                            root: data.monarchTokensProvider
                        }
                    });
                    // Define a new theme that constains only rules that match this language
                    monaco.editor.defineTheme(data.customTheme.id, data.customTheme.theme);
                    theme = data.customTheme.id;
                    monaco.languages.registerCompletionItemProvider(data.id, {
                        provideCompletionItems: () => {
                            return data.completionItemProvider
                        }
                    });
                    var css = document.createElement("style");
                    css.type = "text/css";
                    css.innerHTML = data.monarchTokensProviderCSS;
                    document.body.appendChild(css);
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                });
                // Instruct the editor to remeasure its container
                ipcRenderer.on('layout', function(){
                    editor.layout();
                });
                // need to manually resize the editor any time the window size
                // changes. See: https://github.com/Microsoft/monaco-editor/issues/28
                window.addEventListener("resize", function resizeEditor() {
                    editor.layout();
                });
            </script>
            </body>
            </html>" style="display:inline-flex; width:100%; height:100%" tabindex="-1" guestinstance="4">
</webview>
</div>
</td-code-editor>

But the webview with the base64 string is loaded. In the browser it works perfectly.

I don´t know what I am doing wrong here(I also specify a custom language on the component)

in my source html:

<td-code-editor (keydown)="test($event)" [style.display]="(selectedTab || selectedTab.content != '\t\r') ? 'block' : 'none' " [theme]="editorOptions.theme" automaticLayout [language]="editorOptions.language" [(ngModel)]="selectedTab.content" id="editWindow" #editWindow></td-code-editor>
nagug commented 6 years ago

With 2 beta. This seems to be the same issue :( no errors just not rendering

jeremysmartt commented 6 years ago

I see you are using [(ngModel)] For that to work make sure in your app.module.ts you import the FormsModule:

import { FormsModule } from '@angular/forms';
...
@NgModule({
...
  imports: [
    FormsModule,
...

I tried with this and your snippit of:

<td-code-editor (keydown)="test($event)" [style.display]="(selectedTab || selectedTab.content != '\t\r') ? 'block' : 'none' " [theme]="editorOptions.theme" automaticLayout [language]="editorOptions.language" [(ngModel)]="selectedTab.content" id="editWindow" #editWindow></td-code-editor>

And it worked fine in both the browser and using Covalent-Electron. If by doing this it still doesn't work then can you post a stackblitz of your full code example?

mohitsharma23 commented 6 years ago

Is this issue solved, I'm not getting any error but the editor is still not loading. Using Angular v6 with Electron and trying to implement this editor.

szuni commented 6 years ago

Issue is still present, can't get the editor work based on this boilerpalte: https://github.com/maximegris/angular-electron When I run the app as angular only the editor shows, but it doesn't show in electron.

Stevertus commented 6 years ago

Yes I upgraded to angular 6 and the newest Beta of covalent-code-editor, but the issue is still there. Didn't find a solution yet

nagug commented 6 years ago

Issue is still present, can't get the editor work based on this boilerpalte: https://github.com/maximegris/angular-electron When I run the app as angular only the editor shows, but it doesn't show in electron.

Same issue. I tried with same electron code.

jeremysmartt commented 6 years ago

@szuni @Stevertus @nagug mohitsharma23 Are you also seeing the error when trying with Covalent Electron: https://github.com/Teradata/covalent-electron

Perhaps there is a difference between how Angular-Electron and Covalent-Electron load?

szuni commented 6 years ago

@szuni @Stevertus @nagug mohitsharma23 Are you also seeing the error when trying with Covalent Electron: https://github.com/Teradata/covalent-electron

Perhaps there is a difference between how Angular-Electron and Covalent-Electron load?

Build process is definitely different, because Angular-Electron is built with webpack not gulp. To tell the truth our big application builds much faster with webpack than Covalent-Electron. Could you please help to get code editor work with Angular-Electron?

szuni commented 6 years ago

I could make it work with a dirty solution. First I realized I forgot to copy the file protocol interceptior into electron main.js.

    protocol.interceptFileProtocol('file', function(req, callback) {
      var url = req.url.substr(7);
      const filePath = path.normalize(__dirname + '/../../dist' + url);
      callback( filePath );
    },function (error) {
      if (error) {
        console.error('Failed to register protocol');
      }
    });

Problem is with this solution that there is no dist folder (and any of the assets) generated for development build, application runs somehow from node_modules only. But if I build is frist and then run in dev mode I can use the built assets.

Next problem is with TdCodeEditorComponent. Is uses this._appPath = electron.remote.app.getAppPath().split('\\').join('/');

In my app electron.remote.app.getAppPath() = "P:\ProdDev.Cne-Edit\config-tool\node_modules\electron\dist\resources\default_app.asar" This is for the electron core, not the renderer. I tried to changed it to __dirname with devtool, but somehow that path got confused. With a fixed path it showed up in my electron app.

Any ideas?

nagug commented 6 years ago

@szuni i am also trying to use the same boiler plate as you. for the test home.component.html looks like this

<div class="container">
  <h1 class="title">
    <td-code-editor style="height: 200px" theme="vs-light" flex language="javascript"></td-code-editor>
  </h1>
</div>

what i see as error is in the line

this._appPath = electron.remote.app.getAppPath().split('\').join('/');

is "electron is not defined"!!!

Any advice on how you passed that?

nagug commented 6 years ago

passed that stage by adding electron loader to scripts in angular.json.

Now no errors and no editor :)

szuni commented 6 years ago

select <webview> tag in elements tab and enter $0.openDevtools() in console. Now you will see a new devtool window and the errors of embedded code editor.

nagug commented 6 years ago

That was super helpful. Now both my loader.js and editor.main.css are not found. place it has been looking for the both are

file:///assets/monaco/vs/loader.js
file:///assets/monaco/vs/editor/editor.main.css

Now let me see, hot get that loaded..

nagug commented 6 years ago

These is getting round and round. looks like the dirpath logic inside webview is getting messed up, when using electron-angular. bit crazy :(

szuni commented 6 years ago

I discovered a path override logic used for unit tests. I used it in extended component and got it work:

export class MonacoEditorComponent extends TdCodeEditorComponent {

    constructor(zone: NgZone) {
        super(zone);
        let appPath = electron.remote.app.getAppPath();

        if (appPath.endsWith('default_app.asar')) {
            appPath = appPath.substring(0, appPath.indexOf('node_modules') - 1);
        }
        super.setEditorNodeModuleDirOverride(appPath.split('\\').join('/') + '/dist');
    }
}
nagug commented 6 years ago

@szuni good to hear progress made. I am still in the same stage.

following are my changes in the code compared to base boiler plate

in angular.json

"assets": [
              "src/assets",
              "src/favicon.ico",
              "src/favicon.png",
              "src/favicon.icns",
              "src/favicon.256x256.png",
              "src/favicon.512x512.png",
              "src/electron-load.js",
              {
                "glob": "**/*",
                "input": "node_modules/@covalent/code-editor/assets/monaco",
                "output": "/assets/monaco"
              }

in main.js createwindow function looks like

function createWindow() {
    var electronScreen = electron_1.screen;
    var size = electronScreen.getPrimaryDisplay().workAreaSize;
    protocol.interceptFileProtocol('file', function(req, callback) {
      var url = req.url.substr(7);
      const filePath = path.normalize(__dirname + '/../../dist' + url);
      callback( filePath );
    },function (error) {
      if (error) {
        console.error('Failed to register protocol');
      }
    });
    //Create the browser window.
    win = new electron_1.BrowserWindow({
        x: 0,
        y: 0,
        width: size.width,
        height: size.height,
        webPreferences: {
            webSecurity: false
        }
    });

index.html looks like

<!doctype html>
<html>
<head>
  <meta charset="utf-8">
  <title>AngularElectron</title>
  <base href="">

  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
  <script src="electron-load.js"></script>
</head>
<body>
  <app-root>Loading...</app-root>
</body>
</html>

home component looks like

import { Component, NgZone } from '@angular/core';
import { TdCodeEditorComponent } from '@covalent/code-editor'
var electron = require('electron');

@Component({
  selector: 'app-home',
  templateUrl: './home.component.html',
  styleUrls: ['./home.component.scss']
})
//export class HomeComponent implements OnInit {
export class HomeComponent extends TdCodeEditorComponent {
  constructor(zone: NgZone) {
    super(zone);
    let appPath = electron.remote.app.getAppPath();

    if (appPath.endsWith('default_app.asar')) {
        appPath = appPath.substring(0, appPath.indexOf('node_modules') - 1);
    }
    super.setEditorNodeModuleDirOverride(appPath.split('\\').join('/') + '/dist');
  }
}

home.compoenent.html looks like

<div class="container">
  <h1 class="title">
    {{ 'PAGES.HOME.TITLE' | translate }}
  </h1>
  <td-code-editor style="height: 300px" theme="vs-light" flex language="javascript"></td-code-editor>

</div>

currently the errors I get

in main console

zone-mix.js:3292 ERROR TypeError: Cannot read property 'nativeElement' of undefined
    at HomeComponent.push../node_modules/@covalent/code-editor/esm5/covalent-code-editor.js.TdCodeEditorComponent.ngOnInit (covalent-code-editor.js:464)
    at checkAndUpdateDirectiveInline (core.js:9243)
    at checkAndUpdateNodeInline (core.js:10507)
    at checkAndUpdateNode (core.js:10469)
    at debugCheckAndUpdateNode (core.js:11102)
    at debugCheckDirectivesFn (core.js:11062)
    at Object.eval [as updateDirectives] (HomeComponent_Host.ngfactory.js? [sm]:1)
    at Object.debugUpdateDirectives [as updateDirectives] (core.js:11054)
    at checkAndUpdateView (core.js:10451)
    at callViewAction (core.js:10692)

in webview console

Failed to load resource: net::ERR_FILE_NOT_FOUND editor.main.css
Failed to load resource: net::ERR_FILE_NOT_FOUND loader.js
require.config is not a function

path it is looking for editor.main.css and loader.js looks like

file:///assets/monaco/vs/editor/editor.main.css
file:///assets/monaco/vs/loader.js

really appreciate any inputs.

szuni commented 6 years ago

@nagug try to delete protocol.interceptFileProtocol(...) part from main.js

nagug commented 6 years ago

@szuni Thanks for the input. unfortunately there was no effect.

after some digging, i found that it seems the path for editor.min.css and loader.js is alway wrong. It was never loading full path, but only relative path, causing things to break.

I did some "hardcoding" to covalent-code-editor.js and I was able to make things work.

@jeremysmartt looks like _editorNodeModuleDirOverride not initialised could have some issues on electron. Hence I made some changes like

this._isElectronApp = (( /** @type {?} */(window))['process']) ? true : false;
            if (this._isElectronApp) {
                this._appPath = electron.remote.app.getAppPath().split('\\').join('/');
                this._editorNodeModuleDirOverride = this._appPath;
            }

Now the challenge was the file paths were missing dist

hence I had to change the editorHTML to reflect path with dist included. This is not the right approach. Any suggestions on better approach.

nagug commented 6 years ago

Following are the changes, that made things work for me with angular-electron boiler plate.

in angular.json

"assets": [
              "src/assets",
              "src/favicon.ico",
              "src/favicon.png",
              "src/favicon.icns",
              "src/favicon.256x256.png",
              "src/favicon.512x512.png",
              "src/electron-load.js",
              {
                "glob": "**/*",
                "input": "node_modules/@covalent/code-editor/assets/monaco",
                "output": "/assets/monaco"
              }

main.ts will look like

function createWindow() {

  const electronScreen = screen;
  const size = electronScreen.getPrimaryDisplay().workAreaSize;

  // Create the browser window.
  win = new BrowserWindow({
    x: 0,
    y: 0,
    width: size.width,
    height: size.height,
    webPreferences: {
      webSecurity: false
    }
  });

index.html will look like

<!doctype html>
<html>
<head>
  <meta charset="utf-8">
  <title>AngularElectron</title>
  <base href="">

  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
  <script src="electron-load.js"></script>
</head>
<body>
  <app-root>Loading...</app-root>
</body>
</html>

electron-load.js is the same file as in electron-covalent example. Just that my file only has the following code.

var fs = require('fs');
var electron = require('electron');
var path = require('path');
var url = require('url');

home.component is a empty class

home.component.html is like

<div class="container">
  <h1 class="title">
    {{ 'PAGES.HOME.TITLE' | translate }}
  </h1>
  <td-code-editor style="height: 300px" theme="vs-light" flex language="javascript"></td-code-editor>

</div>

unfortunately the changes are in covalent-code-editor.js (I made the changes in ESM5 files, which is what I was using)

look for the following code

            if (this._isElectronApp) {
                this._appPath = electron.remote.app.getAppPath().split('\\').join('/');
            }

and replace with

            if (this._isElectronApp) {
                this._appPath = electron.remote.app.getAppPath().split('\\').join('/');
                this._editorNodeModuleDirOverride = this._appPath;
            }

this ensures that _editorNodeModuleDirOverride is not empty.

Now need to compensate for delivering from "dist" folder.

Look for the editorHTML in TdCodeEditorComponent.prototype.ngOnInit function. and make the changes for path of the following (Search and change)

/assets/monaco/vs/editor/editor.main.css
/assets/monaco/vs/loader.js

to

/dist/assets/monaco/vs/editor/editor.main.css
/dist/assets/monaco/vs/loader.js

and change the following code also in editorHTML

baseUrl: '" + this._appPath + "/assets/monaco'

to baseUrl: '" + this._appPath + "/dist/assets/monaco'

This is not fully tested for all APIs..so play around with paths.

Stevertus commented 6 years ago

@nagug Thanks that actually worked! Not the best way to fix it, but it is a way. Nevertheless, I hope this gets somehow fixed in the future

Stradivario commented 6 years ago

@nagug tried your solution it doesn't work... maybe i didn't configure it properly... hope it will be resolved soon!

nagug commented 6 years ago

@stradivario what errors are you getting?

Stradivario commented 6 years ago

@nagug sorry yesterday i was a sleep a bit and i didn't say it more correctly.

I don't have any error just my Editor is not showing. I try to change the paths but i think you say it correct "is not suitable for all API-s".

In browser it works perfectly fine.

Regards, K.T.

nagug commented 6 years ago

As @szuni posted.

select tag in elements tab and enter $0.openDevtools() in console. Now you will see a new devtool window and the errors of embedded code editor

This should give clear view of the error.

Stradivario commented 6 years ago

@nagug as @szuni said

select <webview> tag in elements tab and enter $0.openDevtools() in console. Now you will see a new devtool window and the errors of embedded code editor.

I am selecting the element when i enter inside console it says

VM797:1 Uncaught TypeError: $0.openDevtools is not a function
    at <anonymous>:1:4
(anonymous) @ VM797:1
$0.openDevtools()vv
VM803:1 Uncaught SyntaxError: Unexpected identifier
$0.openDevtools()
VM805:1 Uncaught TypeError: $0.openDevtools is not a function
    at <anonymous>:1:4

I don't understand what should i do ?

screenshot from 2018-10-07 19-59-52

Stradivario commented 5 years ago

Any update guys ?

Stradivario commented 5 years ago

Up ? @nagug @jeremysmartt @mohitsharma23 @szuni

Stradivario commented 5 years ago

I manage to select current code editor inside console it says:

Uncaught TypeError: require.config is not a function
    at data:text/html;base64,<!DOCTYPE html>
            <html style="height:100%">
            <head>
                <meta http-equiv="X-UA-Compatible" content="IE=edge" />
                <meta http-equiv="Content-Type" content="text/html;charset=utf-8" >
                <link rel="stylesheet" data-name="vs/editor/editor.main"
                    href="file:///assets/monaco/vs/editor/editor.main.css">
            </head>
            <body style="height:100%;width: 100%;margin: 0;padding: 0;overflow: hidden;">
            <div id="editorInnerContainer0" style="width:100%;height:100%;border:0;"></div>
            <script>
                // Get the ipcRenderer of electron for communication
                const {ipcRenderer} = require('electron');
            </script>
            <script src="file:///assets/monaco/vs/loader.js"></script>
            <script>
                var editor;
                var theme = 'vs-dark';
                var value = '';

                require.config({
                    baseUrl: '/tmp/.mount_angulaaHqQ5i/resources/app.asar/assets/monaco'
                });
                self.module = undefined;
                self.process.browser = true;

                require(['vs/editor/editor.main'], function() {
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: value,
                        language: 'typescript',
                        theme: 'vs-dark',
                    }, {"readOnly":false,"fontSize":14}));
                    editor.getModel().onDidChangeContent( (e)=> {
                        ipcRenderer.sendToHost("onEditorContentChange", editor.getValue());
                    });
                    editor.addAction({
                      // An unique identifier of the contributed action.
                      id: 'fullScreen',
                      // A label of the action that will be presented to the user.
                      label: 'Full Screen',
                      // An optional array of keybindings for the action.
                      contextMenuGroupId: 'navigation',
                      keybindings: [undefined],
                      contextMenuOrder: 1.5,
                      // Method that will be executed when the action is triggered.
                      // @param editor The editor instance is passed in as a convinience
                      run: function(ed) {
                        var editorDiv = document.getElementById('editorInnerContainer0');
                        editorDiv.webkitRequestFullscreen();
                      }
                    });
                    editor.addAction({
                      // An unique identifier of the contributed action.
                      id: 'exitfullScreen',
                      // A label of the action that will be presented to the user.
                      label: 'Exit Full Screen',
                      // An optional array of keybindings for the action.
                      contextMenuGroupId: 'navigation',
                      keybindings: [9],
                      contextMenuOrder: 1.5,
                      // Method that will be executed when the action is triggered.
                      // @param editor The editor instance is passed in as a convinience
                      run: function(ed) {
                        var editorDiv = document.getElementById('editorInnerContainer0');
                        document.webkitExitFullscreen();
                      }
                    });
                    ipcRenderer.sendToHost("onEditorInitialized", this._editor);
                });

                // return back the value in the editor to the mainview
                ipcRenderer.on('getEditorContent', function(){
                    ipcRenderer.sendToHost("editorContent", editor.getValue());
                });

                // set the value of the editor from what was sent from the mainview
                ipcRenderer.on('setEditorContent', function(event, data){
                    value = data;
                    editor.setValue(data);
                });

                // set the style of the editor container div
                ipcRenderer.on('setEditorStyle', function(event, data){
                    var editorDiv = document.getElementById('editorInnerContainer0');
                    editorDiv.style = data.style;
                    var currentValue = editor.getValue();
                    editor.dispose();
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: currentValue,
                        language: data.language,
                        theme: data.theme,
                    }, {"readOnly":false,"fontSize":14}));
                });

                // set the options of the editor from what was sent from the mainview
                ipcRenderer.on('setEditorOptions', function(event, data){
                    editor.updateOptions(data);
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                });

                // set the language of the editor from what was sent from the mainview
                ipcRenderer.on('setLanguage', function(event, data){
                    var currentValue = editor.getValue();
                    editor.dispose();
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: currentValue,
                        language: data,
                        theme: theme,
                    }, {"readOnly":false,"fontSize":14}));
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                    ipcRenderer.sendToHost("onEditorLanguageChanged", '');
                });

                // register a new language with editor
                ipcRenderer.on('registerLanguage', function(event, data){
                    var currentValue = editor.getValue();
                    editor.dispose();

                    for (var i = 0; i < data.completionItemProvider.length; i++) {
                        var provider = data.completionItemProvider[i];
                        provider.kind = eval(provider.kind);
                    }
                    for (var i = 0; i < data.monarchTokensProvider.length; i++) {
                        var monarchTokens = data.monarchTokensProvider[i];
                        monarchTokens[0] = eval(monarchTokens[0]);
                    }
                    monaco.languages.register({ id: data.id });

                    monaco.languages.setMonarchTokensProvider(data.id, {
                        tokenizer: {
                            root: data.monarchTokensProvider
                        }
                    });

                    // Define a new theme that constains only rules that match this language
                    monaco.editor.defineTheme(data.customTheme.id, data.customTheme.theme);
                    theme = data.customTheme.id;

                    monaco.languages.registerCompletionItemProvider(data.id, {
                        provideCompletionItems: () => {
                            return data.completionItemProvider
                        }
                    });

                    var css = document.createElement("style");
                    css.type = "text/css";
                    css.innerHTML = data.monarchTokensProviderCSS;
                    document.body.appendChild(css);

                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                });

                // Instruct the editor to remeasure its container
                ipcRenderer.on('layout', function(){
                    editor.layout();
                });

                // Instruct the editor go to full screen mode
                ipcRenderer.on('showFullScreenEditor', function() {
                  var editorDiv = document.getElementById('editorInnerContainer0');
                  editorDiv.webkitRequestFullscreen();
                });

                // Instruct the editor exit full screen mode
                ipcRenderer.on('exitFullScreenEditor', function() {
                  var editorDiv = document.getElementById('editorInnerContainer0');
                  editorDiv.webkitExitFullscreen();
                });

                ipcRenderer.on('dispose', function(){
                  editor.dispose();
                });

                // need to manually resize the editor any time the window size
                // changes. See: https://github.com/Microsoft/monaco-editor/issues/28
                window.addEventListener("resize", function resizeEditor() {
                    editor.layout();
                });
            </script>
            </body>
            </html>:21:25

Here on 21 line


<!DOCTYPE html>
            <html style="height:100%">
            <head>
                <meta http-equiv="X-UA-Compatible" content="IE=edge" />
                <meta http-equiv="Content-Type" content="text/html;charset=utf-8" >
                <link rel="stylesheet" data-name="vs/editor/editor.main"
                    href="file:///assets/monaco/vs/editor/editor.main.css">
            </head>
            <body style="height:100%;width: 100%;margin: 0;padding: 0;overflow: hidden;">
            <div id="editorInnerContainer0" style="width:100%;height:100%;border:0;"></div>
            <script>
                // Get the ipcRenderer of electron for communication
                const {ipcRenderer} = require('electron');
            </script>
            <script src="file:///assets/monaco/vs/loader.js"></script>
            <script>
                var editor;
                var theme = 'vs-dark';
                var value = '';

                require.config({
                    baseUrl: '/tmp/.mount_angulaaHqQ5i/resources/app.asar/assets/monaco'
                });
                self.module = undefined;
                self.process.browser = true;

                require(['vs/editor/editor.main'], function() {
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: value,
                        language: 'typescript',
                        theme: 'vs-dark',
                    }, {"readOnly":false,"fontSize":14}));
                    editor.getModel().onDidChangeContent( (e)=> {
                        ipcRenderer.sendToHost("onEditorContentChange", editor.getValue());
                    });
                    editor.addAction({
                      // An unique identifier of the contributed action.
                      id: 'fullScreen',
                      // A label of the action that will be presented to the user.
                      label: 'Full Screen',
                      // An optional array of keybindings for the action.
                      contextMenuGroupId: 'navigation',
                      keybindings: [undefined],
                      contextMenuOrder: 1.5,
                      // Method that will be executed when the action is triggered.
                      // @param editor The editor instance is passed in as a convinience
                      run: function(ed) {
                        var editorDiv = document.getElementById('editorInnerContainer0');
                        editorDiv.webkitRequestFullscreen();
                      }
                    });
                    editor.addAction({
                      // An unique identifier of the contributed action.
                      id: 'exitfullScreen',
                      // A label of the action that will be presented to the user.
                      label: 'Exit Full Screen',
                      // An optional array of keybindings for the action.
                      contextMenuGroupId: 'navigation',
                      keybindings: [9],
                      contextMenuOrder: 1.5,
                      // Method that will be executed when the action is triggered.
                      // @param editor The editor instance is passed in as a convinience
                      run: function(ed) {
                        var editorDiv = document.getElementById('editorInnerContainer0');
                        document.webkitExitFullscreen();
                      }
                    });
                    ipcRenderer.sendToHost("onEditorInitialized", this._editor);
                });

                // return back the value in the editor to the mainview
                ipcRenderer.on('getEditorContent', function(){
                    ipcRenderer.sendToHost("editorContent", editor.getValue());
                });

                // set the value of the editor from what was sent from the mainview
                ipcRenderer.on('setEditorContent', function(event, data){
                    value = data;
                    editor.setValue(data);
                });

                // set the style of the editor container div
                ipcRenderer.on('setEditorStyle', function(event, data){
                    var editorDiv = document.getElementById('editorInnerContainer0');
                    editorDiv.style = data.style;
                    var currentValue = editor.getValue();
                    editor.dispose();
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: currentValue,
                        language: data.language,
                        theme: data.theme,
                    }, {"readOnly":false,"fontSize":14}));
                });

                // set the options of the editor from what was sent from the mainview
                ipcRenderer.on('setEditorOptions', function(event, data){
                    editor.updateOptions(data);
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                });

                // set the language of the editor from what was sent from the mainview
                ipcRenderer.on('setLanguage', function(event, data){
                    var currentValue = editor.getValue();
                    editor.dispose();
                    editor = monaco.editor.create(document.getElementById('editorInnerContainer0'), Object.assign({
                        value: currentValue,
                        language: data,
                        theme: theme,
                    }, {"readOnly":false,"fontSize":14}));
                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                    ipcRenderer.sendToHost("onEditorLanguageChanged", '');
                });

                // register a new language with editor
                ipcRenderer.on('registerLanguage', function(event, data){
                    var currentValue = editor.getValue();
                    editor.dispose();

                    for (var i = 0; i < data.completionItemProvider.length; i++) {
                        var provider = data.completionItemProvider[i];
                        provider.kind = eval(provider.kind);
                    }
                    for (var i = 0; i < data.monarchTokensProvider.length; i++) {
                        var monarchTokens = data.monarchTokensProvider[i];
                        monarchTokens[0] = eval(monarchTokens[0]);
                    }
                    monaco.languages.register({ id: data.id });

                    monaco.languages.setMonarchTokensProvider(data.id, {
                        tokenizer: {
                            root: data.monarchTokensProvider
                        }
                    });

                    // Define a new theme that constains only rules that match this language
                    monaco.editor.defineTheme(data.customTheme.id, data.customTheme.theme);
                    theme = data.customTheme.id;

                    monaco.languages.registerCompletionItemProvider(data.id, {
                        provideCompletionItems: () => {
                            return data.completionItemProvider
                        }
                    });

                    var css = document.createElement("style");
                    css.type = "text/css";
                    css.innerHTML = data.monarchTokensProviderCSS;
                    document.body.appendChild(css);

                    ipcRenderer.sendToHost("onEditorConfigurationChanged", '');
                });

                // Instruct the editor to remeasure its container
                ipcRenderer.on('layout', function(){
                    editor.layout();
                });

                // Instruct the editor go to full screen mode
                ipcRenderer.on('showFullScreenEditor', function() {
                  var editorDiv = document.getElementById('editorInnerContainer0');
                  editorDiv.webkitRequestFullscreen();
                });

                // Instruct the editor exit full screen mode
                ipcRenderer.on('exitFullScreenEditor', function() {
                  var editorDiv = document.getElementById('editorInnerContainer0');
                  editorDiv.webkitExitFullscreen();
                });

                ipcRenderer.on('dispose', function(){
                  editor.dispose();
                });

                // need to manually resize the editor any time the window size
                // changes. See: https://github.com/Microsoft/monaco-editor/issues/28
                window.addEventListener("resize", function resizeEditor() {
                    editor.layout();
                });
            </script>
            </body>
            </html>
owilliams320 commented 2 years ago

covalent will not be supported with electron in future versions