fix(markdown): external icon for target _blank

owilliams320 commented 12 months ago

Description

closes #2063

Adding external link icon for links in markdown parsers that use target="_blank"

Test Steps

[ ] npm run start
[ ] then open the docs in browser
[ ] finally look at any documentation file that external links and verify the icon is there

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

Screenshots or link to StackBlitz/Plunker

Screenshot 2023-11-06 at 11 01 06 AM

adamnel commented 12 months ago

Need to remove the underline from the icon on hover:

Otherwise looks good - text is wrapping above and below without the icon pushing the line-height wider on rows where it's present, which was my biggest concern.

owilliams320 commented 8 months ago

:tada: This PR is included in version 8.3.1 :tada:

The release is available on:

v8.3.1
GitHub release

Your semantic-release bot :package::rocket:

Teradata / covalent