Teradata / covalent

Teradata UI Platform built on Angular Material
https://teradata.github.io/covalent/
MIT License
2.23k stars 358 forks source link

fix(app-shell): fix nav-list menu #2162

Closed vicalcantFrontEnd closed 1 month ago

vicalcantFrontEnd commented 1 month ago

Description

What's included?

There was a conflict in the override firstUpdated() method, which caused a block in closing the nav-list menu. To avoid this blockage, the _startResizing method was removed. This resolved both issues: on one hand, the correct closing of the nav-list menu, and on the other hand, resizing to the default size of 320px for the help panel when double-clicking on the resize line.

NOTE : It was found that the line setTimeout(updateActionRibbon, 150) in the file app-shell.stories.js ; is causing the error "Uncaught TypeError: Cannot read properties of undefined (reading '0')". This line introduces a delay before executing updateActionRibbon to ensure that all elements and components are fully initialized.

Removing setTimeout(updateActionRibbon, 150); may avoid the current error, but we need to find a way to ensure that updateActionRibbon only executes after dataTable is fully initialized.

Test Steps

General Tests for Every PR

Screenshots or link to StackBlitz/Plunker
owilliams320 commented 1 month ago

:tada: This PR is included in version 8.12.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: