There was a conflict in the override firstUpdated() method, which caused a block in closing the nav-list menu. To avoid this blockage, the _startResizing method was removed. This resolved both issues: on one hand, the correct closing of the nav-list menu, and on the other hand, resizing to the default size of 320px for the help panel when double-clicking on the resize line.
Fix the problem with the Hamburger Menu on Nav list Menu.
Tested using Covalent 8.12.1
NOTE : It was found that the line setTimeout(updateActionRibbon, 150) in the file app-shell.stories.js ; is causing the error "Uncaught TypeError: Cannot read properties of undefined (reading '0')". This line introduces a delay before executing updateActionRibbon to ensure that all elements and components are fully initialized.
Removing setTimeout(updateActionRibbon, 150); may avoid the current error, but we need to find a way to ensure that updateActionRibbon only executes after dataTable is fully initialized.
Test Steps
[ ] npm run start
[ ] then this
[ ] finally this
General Tests for Every PR
[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
Description
What's included?
There was a conflict in the override firstUpdated() method, which caused a block in closing the nav-list menu. To avoid this blockage, the _startResizing method was removed. This resolved both issues: on one hand, the correct closing of the nav-list menu, and on the other hand, resizing to the default size of 320px for the help panel when double-clicking on the resize line.
NOTE : It was found that the line setTimeout(updateActionRibbon, 150) in the file app-shell.stories.js ; is causing the error "Uncaught TypeError: Cannot read properties of undefined (reading '0')". This line introduces a delay before executing updateActionRibbon to ensure that all elements and components are fully initialized.
Removing setTimeout(updateActionRibbon, 150); may avoid the current error, but we need to find a way to ensure that updateActionRibbon only executes after dataTable is fully initialized.
Test Steps
npm run start
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker