fix(icon-button-toggle): replace property on with toggledOn - Githubissues

Teradata / covalent

Teradata UI Platform built on Angular Material

https://teradata.github.io/covalent/

MIT License

2.23k stars 358 forks source link

fix(icon-button-toggle): replace property on with toggledOn #2175

Closed bsahitya closed 1 month ago

bsahitya commented 1 month ago

Description

While using cv-icon-button-toggle component in angular, if the property on is set in the template, Angular throws an error.

Screenshot 2024-06-11 at 2 38 10 PM

Link to the discussion on this issue: https://github.com/angular/angular/issues/11756

What's included?

Replace on with toggledOn
Change storybook and knapsack docs accordingly

Test Steps

[x] npm run storybook
[x] Navigate to Icon button toggle
[x] Try toggling the cv-icon-button-toggle with the toggledOn property

General Tests for Every PR

[x] npm run start still works.
[x] npm run lint passes.
[x] npm run stylelint passes.
[x] npm test passes and code coverage is not lower.
[x] npm run build still works.

Screenshots or link to StackBlitz/Plunker

Screenshot 2024-06-13 at 6 52 58 PM

Screenshot 2024-06-13 at 6 53 57 PM

owilliams320 commented 1 month ago

:tada: This PR is included in version 8.14.1 :tada:

The release is available on:

v8.14.1
GitHub release

Your semantic-release bot :package::rocket: