search

Teradata / docker-images

Docker images used internally by various Teradata projects for automation, testing, etc
Apache License 2.0
40 stars 22 forks source link

PR for all MapR docker containers #21

Open AS186170 opened 7 years ago

AS186170 commented 7 years ago

PR for all MapR docker containers Please review and give feedback @ArturGajowy @akshatnair @petroav @sanjay990

ArturGajowy commented 7 years ago

I think I'll wait till you apply the comments from the previous review, as they might apply to the kerberos image as well

On Tue, Apr 11, 2017 at 3:49 PM Ashish Singh notifications@github.com wrote:

@AS186170 commented on this pull request.

In teradatalabs/mapr52-hive/files/wardenTracker.sh https://github.com/Teradata/docker-images/pull/21#discussion_r110906462:

@@ -0,0 +1,54 @@ +#!/bin/bash + +hname=$(hostname)

@ArturGajowy https://github.com/ArturGajowy can you review Kerberbos MapR which is new also the test changes we did I will also look into the old PR comments and fix together

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Teradata/docker-images/pull/21#discussion_r110906462, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcFbQE2Rnpu4-FQkPYrmp7xCrycIHPgks5ru4T3gaJpZM4M16co .

AS186170 commented 7 years ago

@ArturGajowy @petroav
All the review comments are done , and tests are also passing , please complete the final review