Product Engineering Review :- Sales Forecasting SAS

[shilpa-nalkande]

Reviewer 1 comments: • Ignored warnings • In section 4, aggregations are done using SQL • In section 5, data merging is done using SQL INNER JOIN. • In section 5, window aggregate rank() is done using SQL query. • In section 5, 6.1 and 6.2, lineplot is done using seaborn. Reviewer 2 comments: • Warnings are ignored • Use of query's to do operations like grouping, joining. • Basic plot like lineplot are formed using plot functionality

Reviewer 1 Suggestions • Ignore only if necessary • In section 4, Use teradataml aggregates. --- Cannot replace as we are showing comparison of SAS SQL and teradatasql • In section 5, Use teradataml's join. --- Cannot replace as we are showing comparison of SAS SQL and teradatasql • In section 5, Use teradataml's window aggregates. --- Cannot replace as we are showing comparison of SAS SQL and teradatasql • In section 5, 6.1 and 6.2, Use teradataml's plot functionality. --- Used in 2 places. Not possible in 3rd as the corr kind of plot is not showing correct values Reviewer 2 Suggestions • do not ignore warnings unless absolutely necessary • In section 4,5 we can use teradataml API like join and group_by and form the DataFrame here instead of creating queries, executing and forming dataframe. • We can use teradataml plot functionality to plot simple plots.

[shilpa-nalkande]

SQLs cannot be changed as we are showing comparison of SAS and Vantage queries