Reviewer 1 comments:
• Do not ignore the warnings.
• In section 3: Select query is used to prepare data.
• matplotlib and seaborn is used for plotting.
• Complete query is not visible.
• zeroifnull, cast and join used in query.
• In section 6: dataframe converted to pandas and again used matplotlib and seaborn for plotting using lineplot.
Reviewer 2 comments:
• In section 4.2, use transform()
• In section 6.4 and 6.5, use Script(), install_file(), remove_file()
Reviewer 1 Suggestions
• Instead of select query user can use select function in teradataml.
• Instead of plotting using matplotlib and seaborn, plot functionality in teradataml can be used which eliminates the need of conversion of dataframe to pandas.
• Instead of using zeroifnull, cast and join in query see if similar functions from teradataml can be used.
Reviewer 2 Suggestions
• instead of using SimpleImputeTransform use fit_obj.transform(data=store)
• use Script(), install_file(), remove_file() from teradataml instead of query and procedure calls like below
Reviewer 1 comments: • Do not ignore the warnings. • In section 3: Select query is used to prepare data. • matplotlib and seaborn is used for plotting. • Complete query is not visible. • zeroifnull, cast and join used in query. • In section 6: dataframe converted to pandas and again used matplotlib and seaborn for plotting using lineplot. Reviewer 2 comments: • In section 4.2, use transform() • In section 6.4 and 6.5, use Script(), install_file(), remove_file() Reviewer 1 Suggestions • Instead of select query user can use select function in teradataml. • Instead of plotting using matplotlib and seaborn, plot functionality in teradataml can be used which eliminates the need of conversion of dataframe to pandas. • Instead of using zeroifnull, cast and join in query see if similar functions from teradataml can be used. Reviewer 2 Suggestions • instead of using SimpleImputeTransform use fit_obj.transform(data=store) • use Script(), install_file(), remove_file() from teradataml instead of query and procedure calls like below