Teradata / jupyter-demos

12 stars 13 forks source link

Product Engineering Review : Carbon_Footprint_Analytics #553

Open nupur-lal opened 3 months ago

nupur-lal commented 3 months ago

Reviewer 1:Shivani Kondewar Reviewer 2:Pooja Chaudhary Reviewer 1 comments: 07 Dec 2023

·        Carbon footprint analysis is done using some model data and analytic capability of Engine. But steps involved in actual analysis are black boxed. Directly DataFrames are created, and plot are plotted. Focus is mostly on the visual representation of analyzed data. ·        Plotted images are not available in notebook.
·        matplotlib, plotly are used for plotting purpose.

Reviewer 2 comments:

·        Dataframe is converted to pandas dataframe everywhere, to use matplotlib or plotly for ploting the values. ·        No plots are visible.

Reviewer 1 Suggestions: 07 Dec 2023

·        If focus of this notebook is on visual representation of analyzed data, then that should reflect in notebook name. If renaming of notebook is not possible, then this should be mentioned in introduction of notebook.

·        Needs recompilation for plot generation.

·        Teradataml's plotting feature can be used over matplotlib, plotly .

Reviewer 2 Suggestions

·        In the notebook, either the scatter_mapbox or bar plot is used from plotly, see if the user can use teradataml plot for displaying the bar plot and scatter plot.