feat(style): pull in theme service and pre-loader

christianmemije commented 4 years ago

Description

What's included?

Pull in theme and pre-loader from ui-platform
Update Angular on the way

Test Steps

[ ] npm ci
[ ] npm run serve
[ ] Login and test this view

Definition of Done

[ ] Adheres to Covalent, Angular-Material & Material Design patterns
[ ] All user-facing strings are properly stored in /src/assets/i18n/en-US.json
[ ] Changes are a11y compliant
[ ] Responsiveness is handled
[ ] npm run lint passes (runs tslint, stylelint, prettier)
[ ] npm run test (unit tests)
[ ] npm run e2e (e2e tests)
[ ] npm run build:prod (AOT, product build test)

Animated Gif

emoralesb05 commented 4 years ago

Also, we really need to change how the theme works to more observable based returning the object we need with the logo, monaco theme and what not. (separate thing tho)

christianmemije commented 4 years ago

Also, we really need to change how the theme works to more observable based returning the object we need with the logo, monaco theme and what not. (separate thing tho)

Opened an issue for this in UI platform since it needs more planning.

christianmemije commented 4 years ago

Waiting on https://github.com/Teradata/vantage-ui-platform/pull/54

christianmemije commented 4 years ago

Addressed both pre-loader and theme comments in ui-platform PRs: teradata/vantage-ui-platform#51 teradata/vantage-ui-platform#54, so ready for re-review.

Teradata / vantage-ui-template