search

Teradata / vantage-ui-template

Template for UI applications in Vantage
MIT License
185 stars 79 forks source link

update ngx-charts to from 3.1.2 to 4.01 #33

Closed dhcdata closed 7 years ago

dhcdata commented 7 years ago

Description

Update ngx-charts version from 3.1.2 to 4.0.1. Renamed ngx-charts.css to index.css in angular-cli.json

emoralesb05 commented 7 years ago

There is an issue with ngx-charts atm that breaks aot builds.

I opened an issue for that https://github.com/swimlane/ngx-charts/issues/194 to keep track of it.

emoralesb05 commented 7 years ago

This is actually not blocked anymore and it works fine in 4.1.1 😄

Can you just resolve the conflict and remove the index.css style? Its not needed anymore.

dhcdata commented 7 years ago

This has already been addressed.

https://github.com/Teradata/covalent/commit/3f0ace5b4b3e599a99a4761891d897abaa05c938

emoralesb05 commented 7 years ago

Well, thats been addressed there, but its still needed in the quickstart.