search

Teradata / vantage-ui-template

Template for UI applications in Vantage
MIT License
185 stars 79 forks source link

ng test #48

Closed kthomas182 closed 5 years ago

kthomas182 commented 7 years ago

ng test fails on standard build of covalent-quickstart

screenshot at mar 01 16-47-06

BartNetJS commented 7 years ago

same here (Windows 10)

msaysell commented 7 years ago

same..

msaysell commented 7 years ago

So I've been looking through this anyway to try and solve my own issues with ng test and it appears as though the commit:

88cc39845eeca3abb7faf3ee59f48629238fd337

Removed the item-list and user-list from the html as well as the items and users from the component so the tests will never pass hence when the test does element.querySelector('.item-list') it gets null back which isn't "truthy", quick fix for anyone interested is just to delete the tests from dashboard-product.component.spec.ts (lines 99-107) but I'd hardly call that a fix

aqupriyanka commented 5 years ago

Added test cases and assigned to @philgetz for review