search

Terasology / Behaviors

Store for an assortment of behaviors that can be applied to creatures
https://terasology.github.io/Behaviors
6 stars 18 forks source link

refactor: address IntelliJ QAPlug plugin findings #114

Open jdrueckert opened 1 year ago

jdrueckert commented 1 year ago

Relates to https://github.com/MovingBlocks/Terasology/pull/5149

jdrueckert commented 12 months ago

Test fails due to the issue being fixed by #115 so we should only merge this after merging #115

soloturn commented 12 months ago

i cannot follow this logic @jdrueckert - this is just reordering imports. no relation with test failures? and #115 itself has test failures.

skaldarnar commented 12 months ago

@soloturn The module is broken currently due to a change in the engine. As the modules don't define on which version of the engine they depend, and the CI always takes the latest available build of develop as base a previously working state of a module might become broken 😔

In this case, even develop is not passing CI, see https://jenkins.terasology.io/job/Terasology/job/Modules/job/B/job/Behaviors/job/develop/1/.

If I understand @jdrueckert correctly, the proposal is to fix the build failure first (intented by #115) before merging anything else.