feat!: Replace Pathfinding with FlexiblePathfinding (part 2)

Terasology / Behaviors

Store for an assortment of behaviors that can be applied to creatures

https://terasology.github.io/Behaviors

6 stars 18 forks source link

feat!: Replace Pathfinding with FlexiblePathfinding (part 2) #89

Closed skaldarnar closed 2 years ago

skaldarnar commented 2 years ago

Follow-up to #88.

Integrates the state of https://github.com/Terasology/FlexibleMovement/commit/e722d750a3fb8e232f731071682f50a9959c173a into this module.

restructure packages to match module guidelines
fixup! restructure packages to match module guidelines
feat!: integrate classes from FlexibleMovement
fixup! feat!: integrate classes from FlexibleMovement
chore!: remove left-over actions using Pathfinding
feat!: add assets from FlexibleMovement

Follow-ups

make use of @In (if possible) or initialization in construct() consistent
formatting of assets (JSON)
formatting of Java files
removing dead and commented code (or revive if necessary)
assess and iterate naming of actions and behaviors
slim down test assets (testcharacter.prefab itself, duplicates in children of parent character prefabs)
align behavior node prefabs for condition, jump, log, setTargetLocalPlayer, setTargetToNearbyBlock with the ones for findPathTo, moveAlongPath and moveTo

jdrueckert commented 2 years ago

@DarkWeird I removed the following behavior node prefabs:

findPathTo.prefab
moveAlongPath.prefab
moveTo.prefab

For each of them you seem to have created a replacement in FlexibleMovement that's copied over here in this PR:

findpathtonode.prefab
movealongpathnode.prefab
movetonode.prefab

Can you tell me what these prefabs are used for?

Also, I noticed the following changes when comparing the originals and their replacements:

removal of action field - why is this not needed anymore?
removal of displayName field - why is this not needed anymore?
replacement of name field value with displayName field value - is this the new "displayName" field?
introduction of type field - where does this come from?

DarkWeird commented 2 years ago

@DarkWeird I removed the following behavior node prefabs:

findPathTo.prefab

moveAlongPath.prefab

moveTo.prefab

For each of them you seem to have created a replacement in FlexibleMovement that's copied over here in this PR:

findpathtonode.prefab

movealongpathnode.prefab

movetonode.prefab

Can you tell me what these prefabs are used for?

Also, I noticed the following changes when comparing the originals and their replacements:

removal of action field - why is this not needed anymore?

removal of displayName field - why is this not needed anymore?

replacement of name field value with displayName field value - is this the new "displayName" field?

introduction of type field - where does this come from?

Seems this prefabs using for BehaviorsEditor only. I don't feel any problem... When haven't thm

jdrueckert commented 2 years ago

FlexibleMovement as a replacement for PathFinding