search

Terasology / Breathing

Allows entities to breathe (or drown/choke) in a particular medium
1 stars 1 forks source link

Smoother breath regain #1

Open Cervator opened 10 years ago

Cervator commented 10 years ago

Like discussed during the PR the logarithmic algorithm for breath regain is a bit rough. It works as intended (big gasping breath right as you get out of water == big jump in air gain) but looks a little "funny" somehow. Probably could be smoother yet still fast at first (rather than instant 4 bubbles warm up over a second or so)

How to Reproduce

  1. Setup iota workspace and add Breathing git clone https://github.com/MovingBlocks/Terasology.git ./groovyw module init iota ./groovyw module get Breathing
  2. Start Terasology, select Core Gameplay and add Breathing in the advanced game setup. `./gradlew jar game
  3. Start the game and find a water body at least 2-3 blocks deep.
  4. Go underwater and let all the oxygen bubbles go away (you breathing bar should be empty).
  5. Emerge from the water and observe that about half of the breathing bar fills up again instantly, the remaining bubbles fill up slower (one by one).
jdrueckert commented 4 years ago

Can confirm that this is still the case in the current develop.