search

Terasology / Cooking

Cook things!
10 stars 55 forks source link

resize #128

Closed developerchan1 closed 7 years ago

smsunarto commented 7 years ago

You can't add a new texture file without accompanying it with a prefab file, and It seems you already deleted your fork repository so I'm closing this PR.

syntaxi commented 7 years ago

@smsunarto I think this is a valid PR. If you have a look at the commits it's resizing the files down to a power of 2. So it is actually a valid pull request.

Also deleting the fork doesn't effect the PR, you have to delete the branch for that. It's odd.

smsunarto commented 7 years ago

@jellysnake it also adds a "stray" texture without the proper prefab file (Meatball). Deleted fork means you can't amend the changes you made anymore, that's why I think this PR should be closed and if he wants to continue he should create a new PR

syntaxi commented 7 years ago

If you look at the changes there's zero additions and zero deletions. It's true there is a stray file but it wasn't added in this pull request.

image

Cervator commented 7 years ago

Also, it would be good to hear from @developerchan1 - hi! It helps if you put some notes in your PR about what you're trying to do :-)