search

Terasology / Cooking

Cook things!
10 stars 55 forks source link

Converted 4 recipes #145

Closed ThunderMan2300 closed 6 years ago

ThunderMan2300 commented 6 years ago

This is an update on my recent pull request, I didn't know how to edit the pull request. It says I updated CookedCorn.prefab but I didn't change anything. And I'm sorry I kind of made a mess on the pull request thing, but I'm new using github.

Cervator commented 6 years ago

Hi there. Yep - the PR is a bit messy, and that's largely because you seem to be using the GitHub web editor, not a source workspace hooked up to work with Git so you can batch multiple files in a single commit and push that.

We've recommended against that in some of our documentation as it is a very poor workflow for this kind of work and easily introduces issues (like problematic whitespace)

Have you gone through and set up a source workspace? Via the guide at https://metaterasology.github.io/docs/developerIntro/fullWorkspace.html. And have you tested the Cooking module to validate that the new recipes work?

I'm going to close this PR so you can make a new one from a different branch you've worked on locally. Please avoid the web editor :-)