search

Terasology / Dialogs

In-Game Dialogs (with NPCs)
Apache License 2.0
2 stars 9 forks source link

fix: NotificationOverlay visibility and alignment #21

Closed skaldarnar closed 4 years ago

skaldarnar commented 4 years ago

The notification overlay was not showing for several reasons. On the one hand it attempts to figure out which button the player has to press, leading to a NPE (fixed by MovingBlocks/Terasology#4256), and on the other hand we must have missed some renaming in the past (asset references are wrong).

As I see these dialog-related notifications more like in-game hints I've moved them to the bottom center of the screen. This is in part to prepare for notifications (e.g., in the form of achievements) to appear in the top-right corner without obstructing these in-game hints:

image

Potential follow-up: Extract the in-game hints from Dialogs into a separate module (possibly unify Notifications, Hints, and WorldlyTooltip/WorldlyTooltipAPI in one configurable module? There's already InGameHelp/InGameHelpAPI...)

jdrueckert commented 4 years ago

Failing tests failed before.