test: add SettlementEntityManagerTest for placeParcel

Terasology / DynamicCities

Cities that get fancy!

17 stars 13 forks source link

test: add SettlementEntityManagerTest for placeParcel #107

Closed keturn closed 3 years ago

keturn commented 3 years ago

Things to look for in review:

null checks in SolidRasterizer: https://github.com/Terasology/DynamicCities/pull/107/files#diff-0359e59a9518a0236f47b3e3fb518e94ba5d0413810d01ca4cf5592c531381e2
Should we try to work around nulls here, or should these be errors? Is there someplace higher-level that should enforce its requirements before it gets here?

Let me know if you want any of the checkstyle fixes or other refactorings split in to other PRs to reduce the noise in this one.

keturn commented 3 years ago

Test set-up has been slow going because everything really, really wants to be configured by prefabs, and I don't know how to add a prefab only for tests. See related discussion in #gestalt.

keturn commented 3 years ago

After some fiddling to make this not dependent on other work-in-progress, this is something like a test case that runs.

It doesn't pass, but it's starting to look like something that could pass.

The changes to the non-test classes are intended to be small refactorings to make the tests a little easier to write, plus some things CheckStyle complained about along the way.