Cervator
commented
6 years ago Hey finally ran across this and tested it out. Yeah looks pretty good, nice work :-)
Although could you add a CheckBlockRegionCondition to it? See dwarfHallsStaircaseDescending.prefab for an example. What seems to happen with this structure is that it spawns halfway sticking out of a hillside since it is so huge plus it doesn't check to make sure everything it replaces is solid. Or it gets spawned with a bunch of other chambers embedded in it due to its size.
Would appreciate any spare effort you might be able to throw at the other dwarf hall prefabs to do similar stuff and help debug follow-ups to https://github.com/MovingBlocks/Terasology/pull/3401 - there are still some quirks after the engine v2 release like stair blocks not placing right and structures not quite lining up correctly :-)
I also tweaked the odds for all the dwarf hall structures to bring them all to more reasonable values plus marked GooeysQuests as a gameplay template (finally). But oddly I couldn't find a way to keep the number of dwarf arenas low, even at spawn chance 1 vs 3-4 digits for other structures. So for the moment until the boundaries/sizing gets checked better I've left the arena disabled at chance 0
Maybe it needs its own type set to a larger base size so chambers can remain the same size and fit together better?
That's pretty much it. Looks good if I do say so myself.