Terasology / GooeysQuests

Go on quests with Gooey, our official mascot!
Apache License 2.0
2 stars 18 forks source link

Added a new dungeon inspired by Saw #6

Closed mdj117 closed 7 years ago

rzats commented 7 years ago

LGTM! @flo you might want to take a look at this 🙂

flo commented 7 years ago

Also there is a syntax error:

Unterminated array at line 784 column 25 path $.SpawnBlockRegions.regionsToFill[776]

mdj117 commented 7 years ago

Will fix the syntax error, but should I define a new type or just define it as like a corridor ? I think I'll define a new type :-)

flo commented 7 years ago

Adding a new structure type doesn't make sense when it does not get used. Basically the structure type defines where it spawns. If you use a structure type that does not get spawned yet then your structure won't be spawned and no one will see it.

Please also have a look at my comments in the other PR. I also explain some basics there.

flo commented 7 years ago

For example the dungeonCorridorLeftTurnSpawner.prefab has the following section that makes it spawn a random structure template of type dungeon3x3StoneCorridor at the relative location of 1 0 3 facing left:

    "ScheduleStructurePlacement" : {
        "placementsToSchedule": [
            {
                "structureTemplateType": "GooeysQuests:dungeon3x3StoneCorridor",
                "front": "LEFT",
                "position": [1, 0, 3]
            }
        ]
    },
flo commented 7 years ago

If you made a new room that has a door sized entrance then use the type dungeon1x2StoneDoorFrame type. If it has a 3x3 wide entrance use dungeon3x3StoneCorridor. If it is a building for outside and a dungeon use type dungeonEntrance. You possibly then also want it to actually spawn a dungeon corridor (like with the json above) so that there is something bigger to explore.

flo commented 7 years ago

Do you still plan to add a spawn condition?

mdj117 commented 7 years ago

as in ?

flo commented 7 years ago

Like

     "CheckBlockRegionCondition" : {
        "checksToPerform": [
            {"condition": "StructureTemplates:IsGroundLike", "region" :{"min": [-3, -1, 1], "size": [7, 7, 6]}}
        ]
    },

And have a look at existing entrance prefab for how to check for air.

mdj117 commented 7 years ago

should I ?

flo commented 7 years ago

otherwise your structure will spawn at very bad locations. Like fore example over something the player built.

mdj117 commented 7 years ago

Umm, Can I do that after GCI ?

flo commented 7 years ago

If this is your task then https://codein.withgoogle.com/dashboard/task-instances/4741269605580800/ I think you started again the wrong task.

flo commented 7 years ago

I tried it out, it still contains the old syntax error.

Once the syntax error is gone, you should be able to find it in the toolbox which can be obtained via "give toolbox" if you use the newest version of the StructureTemplates module.

mdj117 commented 7 years ago

I'll do that in a bit What do I have to do for the task I've currently claimed ?

flo commented 7 years ago

I don't know what your google account is. I suggest you just look up the task description