search

Terasology / JoshariasSurvival

Survival a la Josharias
1 stars 10 forks source link

bugfix: allow to drink without a cup (amount ~ what the cup currently gives) #65

Open pollend opened 3 years ago

pollend commented 3 years ago

@skaldarnar any details with how this should work. keys to press and what not.

4Denthusiast commented 3 years ago

The plausible options for controls that I can think of are left click, right click and "e", with the additional option of this happening unconditionally when you face water, requiring an empty hand, or happening only if there's no other action associated with that combination. I don't think any of the options are perfect, but some are better than others. Rearranging other controls (particularly the fluid container controls) is also an option, but it would be preferable not to.

If it happens unconditionally, then it collides with breaking blocks underwater, placing blocks underwater, or using machines underwater, depending on what button is used. Additionally, it could collide with picking up water with a container. All of these actions may be necessary, so I think this option can be excluded.

If it happens only when there's no other option, it could be a little unpredictable (e.g. you're trying to drink, and it doesn't occur to you that that button actually does something else in this context). Also, in the case of left-click, it could be difficult to drink from small pools which you can reach the bottom of, and in some cases it would be necessary to clear your hand anyway, to avoid doing some other action.

If it happens only with an empty hand, that seems a little unintuitive to me. If it's left click, it would still run into the problem where you can't drink from small pools, or can't dig underwater without a tool or something, depending on the priority order. If it's right-click, that doesn't collide with anything that I'm aware of. If it's "e", it would still collide with using underwater machines.

Left click is associated with removing blocks, and it's the same as picking up liquids with a container, which is similar to what's happening. Right click is used to drink from a container currently. "e" is associated with doing an action relating to the block you're pointing at, which is also what this is, but it's used more rarely, and I think players are less likely to try it.

Overall, I think that right click and requiring an empty hand is probably best. If there are other actions using this combination, drinking should be low priority.