Remove previous scores after restarting game

Terasology / LightAndShadow

Light & Shadow is an experimental game type set in a quirky Alice in Wonderland inspired setting

Apache License 2.0

8 stars 22 forks source link

Remove previous scores after restarting game #159

Closed ahv15 closed 4 years ago

ahv15 commented 4 years ago

Contains

"Fixes #151" The screen with the players and scores from the previously played games are reset when the game is restarted.

How to test

Complete a game once and then restart the game and complete it once again.

Outstanding before merging

[x] Previous game scores do not persist

ahv15 commented 4 years ago

Regarding this issue should I keep track of the players kills and death for the entire duration the player is playing or just for each restarted game?

ahv15 commented 4 years ago

Currently the players stats are not reset after every game.

stefaniamak commented 4 years ago

Regarding this issue should I keep track of the players kills and death for the entire duration the player is playing or just for each restarted game?

In my opinion, I would suggest to reset the K/D 🤔 considering the stats represent each round!

ahv15 commented 4 years ago

Made the change so now the kills and deaths are stored for each game.

ahv15 commented 4 years ago

Cant seem to figure out what went wrong with this, everything seemed fine while testing it and the errors dont seem related to this commit either maybe the error lies elsewhere?

Cervator commented 4 years ago

Heya @ahv15 - just looks like our Artifactory crashed for a bit, meaning all builds would fail. Fixed now and I tried rerunning the build for this :-)

ahv15 commented 4 years ago

thanks @Cervator but it still looks like there is a slight error in here.

Cervator commented 4 years ago

@ahv15 might just be the way I triggered the rebuild didn't fully refresh the commit status checks here. If you click through to the broken build listed by that one commit status you'll see there's a newer one which worked fine :-)

http://jenkins.terasology.io/teraorg/job/Terasology/job/Modules/job/L/job/LightAndShadow/job/PR-159/5/

So as far as build status you're good on this PR, all is well 👍

Cervator commented 4 years ago

Remaining style tweaks were done with https://github.com/Terasology/LightAndShadow/commit/5cb1bf3c5f16bc9dfc8126d252cf2d161760b6d8

ahv15 commented 4 years ago

oops, I really need to watch out for those style issues, seems like I missed out on those tiny issues even though it showed up on checkstyle but I wonder how the tab came in there I was pretty sure there was no problem with that at least.

Cervator commented 4 years ago

No idea! Tabs can be sneaky :-)