Terasology / LightAndShadow

Light & Shadow is an experimental game type set in a quirky Alice in Wonderland inspired setting
Apache License 2.0
8 stars 22 forks source link

stop trees from spawning on team bases by adding LaSTreeProvider and LaSExtraPositionFilters #198

Closed maxjwebber closed 3 years ago

pollend commented 3 years ago

@maxjwebber might still want to look into this? why did you delete it?

maxjwebber commented 3 years ago

@maxjwebber might still want to look into this? why did you delete it?

Didn't realize changing a branch name would close related pull requests. I changed the name back and reopened the request.

skaldarnar commented 3 years ago

Not sure where I left this commment (probably some GSOC proposal), but I don't think we need a custom tree provider here. Instead, it should be possible to make use of the fact that trees are only generated on the surface, and therefore modifying the surface facet should do the trick. Lakes do this to avoid that grass spawns on the water.

That said, I give you credit for the abstraction to allow for additional filters (to expand it later on) :nerd_face:

jdrueckert commented 3 years ago

The issue this was attempting to fix was fixed by #216