search

Terasology / LightAndShadow

Light & Shadow is an experimental game type set in a quirky Alice in Wonderland inspired setting
Apache License 2.0
8 stars 22 forks source link

fix: don't update kill statistics if player died of own account #242

Closed ujjman closed 2 years ago

ujjman commented 2 years ago

This PR is to fix issue https://github.com/Terasology/LightAndShadow/issues/234

ujjman commented 2 years ago

I think we can update the deaths counter of the player but I think it would be unfair to do so because the player died by itself and not being killed by the other player. So what do you think?

jdrueckert commented 2 years ago

That the player wasn't killed by a person but on their own account is a good point, but it's still a death, so is it really unfair? 🤔 I would be interested in what @skaldarnar has to say about this as we talked about not punishing players, but only rewarding them...

jdrueckert commented 2 years ago

@ujjman Had a quick check offline with @skaldarnar and he agrees, that we should count it in the deaths statistic.