search

Terasology / ModuleTestingEnvironment

3 stars 15 forks source link

Create fixture for observing item drops #2

Closed aaron-harris closed 6 years ago

aaron-harris commented 6 years ago

Contains

A new test fixture for observing item drops. I created this for the tests I am currently writing for the SimpleFarming module but felt that it belongs here instead, since nothing about it is specific to that module.

Cervator commented 6 years ago

If you approve it feel free to merge it :-)

Is the generics thing anything to worry about? Will wait just a bit longer to hear back from either of you or maybe @kaen

aaron-harris commented 6 years ago

@oniatus, not sure I followed that bit about the generics. I think what you mean is that the eventual generalization of this class would need to be parametrized, say AbstractEventSpy <T> where T is the type of event we want to spy on, with a similarly-parametrized event handler, and that will cause difficulties because the event system won't know what class of event to register it to. Is that right, or is there something going on with the current incarnation too?

oniatus commented 6 years ago

That's right :) I suggest to keep it in mind if we ever need a similar logic. For now it should be fine. I would like to leave merge for kaen as he is basically the creator of this module.

kaen commented 6 years ago

@aaron-harris could you check out #3 and see if it covers your use case?

aaron-harris commented 6 years ago

@kaen #3 looks great! I left a couple comments over there, but that's mostly nitpicking or for my own edification. Closing this one in favor of yours.