search

Terasology / ModuleTestingEnvironment

3 stars 15 forks source link

fix: make sure the module under test depends on engine #47

Closed keturn closed 3 years ago

keturn commented 3 years ago

There's redundancy with ModuleManager.ensureModulesDependOnEngine, but ModuleManager can't enforce this everyone goes around adding to its Registry directly.

Fixes #45, the failure to load built-in engine assets, I hope.

keturn commented 3 years ago

did not fix bug. it did change the error message though, so that's something.

average run time to get test results for this repo from CI is 13 minutes. Really need a way to reproduce this failure locally so I can run just that test. Maybe set up a https://github.com/MovingBlocks/ModuleJteConfig workspace locally?

keturn commented 3 years ago

45 was fixed by a change to engine. Closing this, but it might come up again in some other form.