search

Terasology / PolyWorld

A world generator that is based on Voronoi diagrams
81 stars 19 forks source link

Rename class Region to GraphRegion #24

Closed meetcshah19 closed 4 years ago

meetcshah19 commented 4 years ago

The naming Region clashes with another class in the engine and GraphRegion is more accurate to describe what the class is about.

gaurav9822 commented 4 years ago

@meetcshah19 @jdrueckert can I take this issue?

meetcshah19 commented 4 years ago

Yes @gaurav9822

jdrueckert commented 4 years ago

@gaurav9822 Actually we already have somebody working on this (see https://github.com/Terasology/PolyWorld/pull/26). However as mentioned in the linked there's a second PR in Lost required to fully support this. So if you'd like you can take that.

skaldarnar commented 4 years ago

Fixed by #26