search

Terasology / Rails

Base rail module for minecarts and such
10 stars 17 forks source link

test: re-enable MTE tests #80

Closed skaldarnar closed 3 years ago

keturn commented 3 years ago

I'm confused about test run 5 on this branch. 'cuz that was after the four-minute limit was merged.

does the timeout not work like I hoped? is it particular to CI? or does this test somehow lock up so hard that jupiter couldn't interrupt it?

the other runs passed in normal amounts of time.

skaldarnar commented 3 years ago

I'm confused about test run 5 on this branch. 'cuz that was after the four-minute limit was merged.

does the timeout not work like I hoped? is it particular to CI? or does this test somehow lock up so hard that jupiter couldn't interrupt it?

the other runs passed in normal amounts of time.

I'm not 100% sure this was long enough after the engine merge (i.e., whether this run already picked up that change or not...). But the 3 hours shown in the Jenkins overview are even way higher than the 1 hour that should be configured 🧐

On another note: I'm not sure how reliable these logs are, but it seems that it stalls on trying to place blocks in the world. Resetting test area ... is logged before we start using the worldProvider, and the next message should have been after placing all air blocks...

  23:41:01.857 [Test worker] INFO  org.terasology.minecarts.RailsTest - ✓ successfully resolved block family
  23:41:01.857 [Test worker] INFO  org.terasology.minecarts.RailsTest - Resetting test area ...
  23:41:01.908 [Test worker] WARN  o.t.engine.core.internal.TimeBase - Delta too great (1455), capping to 1000
skaldarnar commented 3 years ago

I did a quick test with TestInstanceLifeCycle is per-class some time ago, but run into issues. I think we should get back at this, otherwise we'll just forget about these tests...

jdrueckert commented 3 years ago

Re-enable Rails MTE Tests

skaldarnar commented 3 years ago

Superseded by #87