search

Tercioo / Details-Damage-Meter

Addon for World of Warcraft, does combat analyzes offering clean visual data for the player
Other
178 stars 131 forks source link

[Classic] Show Pets When in Party #55

Open nmonterroso opened 4 years ago

nmonterroso commented 4 years ago

Not an issue, but a feature request. Before getting into details (no pun intended) I'll say that I'm willing to do this myself via a PR from a forked repo, if this is something you'd be interested in having.

I'd like the option to show pets when in a group. I see that this is currently disabled in a couple places with the conditional:

if (UnitExists ("pet") and not IsInInstance() and false) then --disabled

Is there a historical reason for this? I am unsure which tag represents the current classic release (version DetailsClassic.1.13.3.196.142), so I can't git blame the reason those changes were added. I removed the and false and from my limited testing the threat meter worked as expected.

What I'm picturing is an additional option in plugin management -> raid plugins -> tiny threat -> options with the following:

"Show [my pet|all pets] when [solo|in a party|in a raid]"

Where [my pet|all pets] and [solo|in a party|in a raid] are drop downs. Maybe omit the "in a raid" since that is unlikely to be useful.

What do you think? Again - I'm willing to contribute, just need a point in the right direction :)

VincentVancalbergh commented 4 years ago

The grouping of pets may be explained that, when reviewing damage logs, your pet's damage is usually considered part of your own. This doesn't make sense when talking about threat though, since it's now impossible to see where your pet is in regards to the tank (or yourself).

VincentVancalbergh commented 4 years ago

Personally I have a hard time understanding why it is ever considered okay not to show ALL pet threat levels. How am I supposed to know when I'm pulling aggro from the Voidwalker that is offtanking a mob.

And when I'm farming Fire Elementals solo in Un'Goro I know that, if I let my pet build 1.6K threat I'm free to open with Aimed Shot and a Multi Shot immediately after and I won't draw aggro. But I enter in a group with someone on another continent and suddenly I no longer care about that? Preposterous.

b-morgan commented 3 years ago

While this over a year old, I came here looking for just this feature. When soloing a hunter or a warlock, knowing my threat / damage vs. my pet / minion's threat / damage is extremely useful. Also useful in a group.

Tercioo commented 3 years ago

Which game version?

------ Original Message ------ From: "Brad Morgan" @.> To: "Tercioo/Details-Damage-Meter" @.> Cc: "Subscribed" @.***> Sent: 09-May-21 8:04:26 AM Subject: Re: [Tercioo/Details-Damage-Meter] [Classic] Show Pets When in Party (#55)

While this over a year old, I came here looking for just this feature. When soloing a hunter or a warlock, knowing my threat / damage vs. my pet/minion's threat / damage is extremely useful. Also useful in a group.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/55#issuecomment-835782397, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEVKWHLAFV36K5LLBQY6NDTMZT3VANCNFSM4LEXQO7A.

VincentVancalbergh commented 3 years ago

1.13.7 and 2.5.1

b-morgan commented 3 years ago

Classic version 1.13.7 (Details! C217). I would hope that changes to Classic would also apply to Burning Crusade Classic.