search

Tercioo / Details-Damage-Meter

Addon for World of Warcraft, does combat analyzes offering clean visual data for the player
Other
165 stars 117 forks source link

[TWW] Fix new spell book function causing nil values errors #753

Closed Daemon34 closed 2 weeks ago

Daemon34 commented 2 weeks ago

Fix multiple lua errors on The War Withing Beta happening when joining a group :

Tercioo commented 2 weeks ago

thank you!, I'll check this still today!

Andyauk commented 2 weeks ago

Fix multiple lua errors on The War Withing Beta happening when joining a group :

  • Fixed nil values errors on IsPassiveSpell, GetSpellCharges, GetSpellBookItemName because of new C_Spell and C_SpellBook API
  • Use Enum.SpellBookSpellBank.Pet instead of "pet" and use spellBookPlayerEnum instead of "player" to avoid issues when calling SpellBook functions using book type argument
  • Fix issue on GetSpellCooldown returning new SpellCooldownInfo structure which caused start and duration local to be of type table and nil

great job, works fine.

Tercioo commented 2 weeks ago

Thank you so much for the fix!

Tercioo commented 2 weeks ago

Retail bugged on /reload

1x ...ns/Details/Libs/LibOpenRaid/GetPlayerInformation.lua:825: attempt to index local 'spellCooldownInfo' (a number value) [string "@Details/Libs/LibOpenRaid/GetPlayerInformation.lua"]:508: in function <...ns/Details/Libs/LibOpenRaid/GetPlayerInformation.lua:507> [string "@Details/Libs/LibOpenRaid/GetPlayerInformation.lua"]:732: in function GetPlayerCooldownList' [string "@Details/Libs/LibOpenRaid/LibOpenRaid.lua"]:2469: in functionSendAllPlayerCooldowns' [string "@Details/Libs/LibOpenRaid/LibOpenRaid.lua"]:1083: in function <...faceDetails/Libs/LibOpenRaid/LibOpenRaid.lua:1075> [string "=[C]"]: in function `xpcall' [string "@Details/Libs/LibOpenRaid/LibOpenRaid.lua"]:602: in function <...faceDetails/Libs/LibOpenRaid/LibOpenRaid.lua:587>

Tercioo commented 2 weeks ago

fixed.