search

Tercioo / Details-Damage-Meter

Addon for World of Warcraft, does combat analyzes offering clean visual data for the player
Other
165 stars 117 forks source link

In Cataclysm Classic Dungeon Finder instances and only inside them, the player's hunter pet's damage is not attributed to the player's damage, but other hunters' pets' damage are attributed to their owners' damage #759

Open AlexFolland opened 1 week ago

AlexFolland commented 1 week ago

Game and Details! version

Cataclysm Classic

VWD 12801 ALPHA 58 4.4.0

Steps to reproduce

  1. Play as a hunter in Cataclysm Classic.
  2. Attack enemies as usual outside a dungeon and observe combined pet damage in the Details damage window.
  3. Use the dungeon finder menu to queue for a random dungeon.
  4. Await and then join the dungeon. If there is no other hunter, finish the dungeon and go to step 3.
  5. Attack enemies as usual inside the dungeon finder instance and observe that the player's hunter pet's damage is not attributed to the player's damage, but other hunters' pets' damage are attributed to their owners' damage.

Observed behavior

In Cataclysm Classic Dungeon Finder instances and only inside them, the player's hunter pet's damage is not attributed to the player's damage, but other hunters' pets' damage are attributed to their owners' damage.

Expected behavior

All hunters' pets' damage, healing, and other logged effects are expected to always be attributed to their owners.

When did the bug first manifest (a date, wow path release, details update, etc.)?

I don't know since I just came back to playing 2 days ago. I first observed it the day after I started playing Cataclysm Classic on my hunter, when I ran my first dungeon finder instance. That was 2 days ago; 2024-06-18. The issue may have been reproducible longer than that.

Lua Errors

I see no Lua errors from Details with or without other addons enabled.

Screenshots

image

Other Information

I can manually calculate my total damage by switching from "Standard" to "Everything" view and adding my pet's damage to mine. This is a major inconvenience though.

Flamanis commented 1 week ago

Can you screenshot the window showing your pet?

AlexFolland commented 1 week ago

Here. I think this captures the requested information.

image

Flamanis commented 1 week ago

Could you get a combatlog file of this occuring?

AlexFolland commented 1 week ago

OK, I did. Here it is.

WoWCombatLog-062324_213933.txt

Flamanis commented 1 week ago

Did this log come from you personally? Or another player?

On Sun, Jun 23, 2024, 11:48 PM Alex Folland @.***> wrote:

OK, I did. Here it is.

WoWCombatLog-062324_213933.txt https://github.com/user-attachments/files/15949915/WoWCombatLog-062324_213933.txt

— Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/759#issuecomment-2185597939, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL4J6FEOBG746YTQWMEPSLZI6QKLAVCNFSM6AAAAABJVM4A72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGU4TOOJTHE . You are receiving this because you commented.Message ID: @.***>

AlexFolland commented 1 week ago

Me personally. My character is Bujuhunter and my pet is Bujupet.

Flamanis commented 1 week ago

I was hoping you weren't going to say that. Log shows your events are occurring with your name containing your realm name, with your pet not having your realm name. I'll check in the morning personally if that is the case for the issue

On Mon, Jun 24, 2024, 12:17 AM Alex Folland @.***> wrote:

Me personally. My character is Bujuhunter and my pet is Bujupet.

— Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/759#issuecomment-2185625073, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL4J6EIMXX2MS5AM2RTFQTZI6TW3AVCNFSM6AAAAABJVM4A72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGYZDKMBXGM . You are receiving this because you commented.Message ID: @.***>

AlexFolland commented 1 week ago

I didn't manually edit the combat log, so I don't think you'd need to check personally if that's the case. You can see it in my combat log.

Flamanis commented 1 week ago

In game events dont always line up with out of game, so i need to check that against hunter pets and see what we might be doing wrong when trying to detect

On Mon, Jun 24, 2024, 12:47 AM Alex Folland @.***> wrote:

I didn't manually edit the combat log, so I don't think you'd need to check personally if that's the case. You can see it in my combat log.

— Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/759#issuecomment-2185660699, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL4J6AS7K5CX7FBPM4NTA3ZI6XGVAVCNFSM6AAAAABJVM4A72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGY3DANRZHE . You are receiving this because you commented.Message ID: @.***>