I get GetPetNameFromCustomSpells every 3-4 seconds.

[emrediga]

• Steps to Reproduce (what did you do to make the bug happen): I disabled all addons. And only details were enabled. I also deleted saved variables. https://imgur.com/a/0qnDM0n

• Result (what happens when you follow the steps above): Everytime i log in to my account i get 4 lua errors.

• Expected (what you think the expected behavior would be when following the steps):

• When the bug started (a date, wow path release, details update, etc)? Everytime i log in to my account i get 4 lua errors. No need to be in combat. i get this lua error every 2-3 second.

• Additional information:

Lua Error First lua error: Message: Interface/AddOns/Details/functions/spellcache.lua:248: attempt to concatenate a nil value Time: Wed Jul 24 14:57:41 2024 Count: 1 Stack: Interface/AddOns/Details/functions/spellcache.lua:248: attempt to concatenate a nil value

Locals:

Second Lua Error Message: Interface/AddOns/Details/startup.lua:503: attempt to call method 'GetDefaultCustomItemList' (a nil value) Time: Wed Jul 24 14:57:45 2024 Count: 1 Stack: Interface/AddOns/Details/startup.lua:503: attempt to call method 'GetDefaultCustomItemList' (a nil value) [string "@Interface/AddOns/Details/startup.lua"]:503: in function `StartMeUp' [string "@Interface/AddOns/Details/core/parser.lua"]:6369: in function <Interface/AddOns/Details/core/parser.lua:6368>

Locals: lowerInstanceId = 1 (temporary) = nil (temporary) =

{ APITopics = { } player_stats = { } resize_debug = { } overall_flag = 16 opened_windows = 2 PotionList = { } default_bg_color = 0.094100 show_totalhitdamage_on_overkill = false color_by_arena_team = true plugin_window_pos = { } gump = { } InstancesToStoreData = { } default_skin_to_use = "Minimalistic" gametoc = 110000 deadlog_events = 32 last_instance_id = 1209 atributo_energy = { } show_warning_id1 = true FadeHandler = { } AddOnStartTime = 17952.961000 ToolBar = { } listener = Frame { } time_type_original = 2 all_in_one_windows = { } deathlog_healingdone_min_arena = 400 overall_clear_newboss = true overlay_frame = Frame { } breakdown_spell_tab = { } PluginDefaults = { } bitfield_debuffs_table = { } lastBattlegroundStartTime = 17952.961000 encounter_end_table = { } aura_tracker_frame = { } options_group_edit = true mythic_plus = { } switchSaved = { } savedStyles = { } SHADOWLANDSCORE = 143 tooltip_backdrop = { } use_row_animations = true RecordPlayerSelfDebuffs = false windows_fade_out = { } death_tooltip_width = 350 ps_abbreviation = 3 pvp_as_group = true segments_amount_boss_wipes = 10 use_self_color = false hooks = { } network = { } ShieldCache = { } announce_cooldowns = { } atributo_misc = { } table = { } default_backdropcolor = { } hotcorner_topleft = { } segments_auto_erase = 1 BitfieldSwapDebuffsSpellIDs = { } only_pvp_frags = false cache_damage_group = { } custom_function_cache = { } SpellsToIgnore = { } barras_criadas = 0 minimum_overall_combat_time = 10 icones = { } divisores = { } SoloTables = { } clear_ungrouped = true barras_max_index = 11 role_texcoord_normalized = { } spellcache = { } installed_skins_cache = { } ClassSpellList = { } spells_school = { } specToRole = { } classid_to_classstring = { } left_anti_truncate = DetailsLeftTextAntiTruncate { } latest_encounter_spell_pool_access = 1721808315 boss_mods_timers = { } faction_id = 1 tooltip_border_color = { } max_window_size = { } HarmfulSpells = { } spell_category_savedtable = { } custom = { } ocd_tracker = { } event_tracker = { } debug = false refresh = { } packFunctions = { } classstring_to_classid = { } global_plugin_database = { } preset_version = 3 tooltip_key_overlay1 = { } atributo_damage = { } RecordPlayerSelfBuffs = false RegistredEvents = { } menu_backdrop_config = { } scroll_speed = 2 Colors = { } clear_graphic = true data_harvested_for_charts = { } capture_schedules = { } data_wipes_exp = { } encounter_counter = { } battleground_info = { } yesNo = { } userversion = "11.0.0 12816" instances_segments_locked = true defaultModuleState = true bookmark_text_size = 11 spell_category_latest_sent = 0 windows_fade_in = { } cooltip_preset3_backdrop = { } container_habilidades = { } habilidade_cura =

3rd Lua Error Message: Interface/AddOns/Details/startup.lua:28: attempt to call method 'FillUserCustomSpells' (a nil value) Time: Wed Jul 24 14:57:48 2024 Count: 1 Stack: Interface/AddOns/Details/startup.lua:28: attempt to call method 'FillUserCustomSpells' (a nil value) [string "@Interface/AddOns/Details/startup.lua"]:28: in function <Interface/AddOns/Details/startup.lua:26>

Locals: (temporary) = nil (temporary) =

{ APITopics = { } player_stats = { } resize_debug = { } overall_flag = 16 opened_windows = 2 PotionList = { } default_bg_color = 0.094100 show_totalhitdamage_on_overkill = false color_by_arena_team = true plugin_window_pos = { } gump = { } InstancesToStoreData = { } default_skin_to_use = "Minimalistic" gametoc = 110000 deadlog_events = 32 last_instance_id = 1209 atributo_energy = { } show_warning_id1 = true FadeHandler = { } AddOnStartTime = 17952.961000 ToolBar = { } listener = Frame { } time_type_original = 2 all_in_one_windows = { } deathlog_healingdone_min_arena = 400 overall_clear_newboss = true overlay_frame = Frame { } breakdown_spell_tab = { } PluginDefaults = { } bitfield_debuffs_table = { } lastBattlegroundStartTime = 17952.961000 encounter_end_table = { } aura_tracker_frame = { } options_group_edit = true mythic_plus = { } switchSaved = { } savedStyles = { } SHADOWLANDSCORE = 143 tooltip_backdrop = { } use_row_animations = true RecordPlayerSelfDebuffs = false windows_fade_out = { } death_tooltip_width = 350 ps_abbreviation = 3 pvp_as_group = true segments_amount_boss_wipes = 10 use_self_color = false hooks = { } network = { } ShieldCache = { } announce_cooldowns = { } atributo_misc = { } table = { } default_backdropcolor = { } hotcorner_topleft = { } segments_auto_erase = 1 BitfieldSwapDebuffsSpellIDs = { } only_pvp_frags = false cache_damage_group = { } custom_function_cache = { } SpellsToIgnore = { } barras_criadas = 0 minimum_overall_combat_time = 10 icones = { } divisores = { } SoloTables = { } clear_ungrouped = true barras_max_index = 11 role_texcoord_normalized = { } spellcache = { } installed_skins_cache = { } ClassSpellList = { } spells_school = { } specToRole = { } classid_to_classstring = { } left_anti_truncate = DetailsLeftTextAntiTruncate { } latest_encounter_spell_pool_access = 1721808315 boss_mods_timers = { } faction_id = 1 tooltip_border_color = { } max_window_size = { } HarmfulSpells = { } zone_type = "none" spell_category_savedtable = { } custom = { } ocd_tracker = { } event_tracker = { } debug = false refresh = { } packFunctions = { } classstring_to_classid = { } global_plugin_database = { } preset_version = 3 tooltip_key_overlay1 = { } atributo_damage = { } RecordPlayerSelfBuffs = false RegistredEvents = { } menu_backdrop_config = { } scroll_speed = 2 Colors = { } clear_graphic = true data_harvested_for_charts = { } capture_schedules = { } data_wipes_exp = { } encounter_counter = { } battleground_info = { } yesNo = { } userversion = "11.0.0 12816" instances_segments_locked = true defaultModuleState = true bookmark_text_size = 11 spell_category_latest_sent = 0 windows_fade_in = { } cooltip_preset3_backdrop = { } container_habilidades = { } habilidade_cura = { } raid_data = { } options_window = { } minimum_combat_time = 5 __profiles =

This is the annoying lua error i get everytime Message: Interface/AddOns/Details/core/parser.lua:2310: attempt to call field 'GetPetNameFromCustomSpells' (a nil value) Time: Wed Jul 24 15:01:33 2024 Count: 19 Stack: Interface/AddOns/Details/core/parser.lua:2310: attempt to call field 'GetPetNameFromCustomSpells' (a nil value) [string "@Interface/AddOns/Details/core/parser.lua"]:2310: in function <Interface/AddOns/Details/core/parser.lua:2276>

Locals: self = nil token = "SPELL_SUMMON" time = 1721822493.126000 sourceSerial = "Player-1084-0AC49F26" sourceName = "Geolock" sourceFlags = 1297 petGuid = "Creature-0-3061-2548-263-143622-000020ED1D" petName = "Wild Imp" petFlags = 2600 petRaidFlags = 0 summonSpellId = 279910 summonSpellName = "Wild Imp" npcId = 143622 (temporary) = nil (temporary) = "Wild Imp" (temporary) = 279910 (temporary) = 143622 (*temporary) = "attempt to call field 'GetPetNameFromCustomSpells' (a nil value)" Details222 =

{ PlayerStats = { } Cache = { } ClassCache = { } UnitIdCache = { } CustomItemList = { } PetContainer = { } SpecHelpers = { } PFrame = Frame { } TimeMachine = { } Roskash = { } ColorScheme = { } Unknown = "Unknown" EncounterJournalDump = { } BarIconSetList = { } OneHourAuras = { } CurrentDPS = { } Mixins = { } Parser = { } EJCache = { } AutoRunCode = { } MythicPlusBreakdown = { } Actors = { } Combat = { } SaveVariables = { } Tvs = 110000 Scheduler = { } LoadSavedVariables = { } GarbageCollector = { } OptionsPanel = { } WarcraftLogs = { } IgnoredWorldAuras = { } DamageSpells = { } OnUseItem = { } ProfilingCache = { } Cooldowns = { } TrainingDummiesNpcId = { } StartUp = { } Date = { } Instances = { } Pets = { } Segments = { } AuraScan = { } PrivateInstanceText = FontString { } Perf = { } Textures = { } Profiling = { } Debug = { } Tables = { } CooldownTracking = { } ParsePercent = { } TimeCapture = { } GuessSpecSchedules = { } MythicPlus = { } parser_frame = Frame { } PlayerBreakdown = { } BreakdownWindow = { } storage = { } RegisteredFramesToColor = { } } dk_pets_cache = { army = { } apoc = { } } isWOTLK = false isCATA = false petContainer = { IgnoredActors = { } UnitPetCache = { } Pets = { } } petCache = { Pet-0-3061-2548-178-17252-0403BC0EF4 = { } }

Screenshots https://imgur.com/3dqy9HQ https://imgur.com/SSeDbgq

Combat Log No need to see any combat log. https://imgur.com/BZlfopw

spencerneutron commented 3 months ago

Just chiming in here, this issue ultimately stems from a failure to retrieve the spell details for Ebon Might in the custom spells lookup.

It seems like whenever it's being built, the spell customization table is unable to retrieve the spell info for ebon might. (Note: If you run this afterwards, it seems like the spell info is eventually made available. Perhaps the spell cache isn't fully loaded at first?)

Proposed temporary workaround:

Change line 248 in functions/spellcache.lua from

[395296] = {name = GetSpellInfo(395296) .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

to

[395296] = {name = (GetSpellInfo(395296) or "none") .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

Making this hotfix resolved all of my on-login lua errors stemming from this initial concat issue.

Flamanis commented 3 months ago

Just update. This has been fixed

On Wed, Jul 24, 2024, 2:57 PM Spencer @.***> wrote:

Just chiming in here, this issue ultimately stems from a failure to retrieve the spell details for Ebon Might in the custom spells lookup.

It seems like whenever it's being built, the spell customization table is unable to retrieve the spell info for ebon might. (Note: If you run this afterwards, it seems like the spell info is eventually made available. Perhaps the spell cache isn't fully loaded at first?)

Proposed temporary workaround:

Change line 248 in functions/spellcache.lua from

[395296] = {name = GetSpellInfo(395296) .. " (on your self)", icon = "Interface\Addons\Details\images\ebon_might"},

to

[395296] = {name = (GetSpellInfo(395296) or "none") .. " (on your self)", icon = "Interface\Addons\Details\images\ebon_might"},

Making this hotfix resolved all of my on-login lua errors stemming from this initial concat issue.

— Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/785#issuecomment-2248792877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL4J6ET72J6YSDIK3I5273ZOABJPAVCNFSM6AAAAABLMLLDVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYG44TEOBXG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Flamanis commented 3 months ago

Just chiming in here, this issue ultimately stems from a failure to retrieve the spell details for Ebon Might in the custom spells lookup.

It seems like whenever it's being built, the spell customization table is unable to retrieve the spell info for ebon might. (Note: If you run this afterwards, it seems like the spell info is eventually made available. Perhaps the spell cache isn't fully loaded at first?)

Proposed temporary workaround:

Change line 248 in functions/spellcache.lua from

[395296] = {name = GetSpellInfo(395296) .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

to

[395296] = {name = (GetSpellInfo(395296) or "none") .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

Making this hotfix resolved all of my on-login lua errors stemming from this initial concat issue.

To explain whats actually going on: You have blizzard deprecation fallbacks enabled, which readds removed/soon to be removed functions. These were being used as if they were the new version of them, causing issues elsewhere. Newest releases fix this behavior

spencerneutron commented 3 months ago

@Flamanis

That's awesome! I'm not very familiar with this codebase yet, and I didn't realize that GetSpellInfo was a function coming from the addon/LibOpenRaid. I figured there was more going on than just some dysfunctional timing there.

Reading your PR #789 was helpful

Flamanis commented 3 months ago

It technically is not coming from libopenraid. It comes from blizzard, and TWW moved it to a new location/variable. They also changed the format of the information it gives back.

Blizzard added a cvar that loads the old functions (removed on tww launch)

LibOpenRaid was pulling the old and using it in place of the new

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[spencerneutron]

Just chiming in here, this issue ultimately stems from a failure to retrieve the spell details for Ebon Might in the custom spells lookup.

It seems like whenever it's being built, the spell customization table is unable to retrieve the spell info for ebon might. (Note: If you run this afterwards, it seems like the spell info is eventually made available. Perhaps the spell cache isn't fully loaded at first?)

Proposed temporary workaround:

Change line 248 in functions/spellcache.lua from

[395296] = {name = GetSpellInfo(395296) .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

to

[395296] = {name = (GetSpellInfo(395296) or "none") .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

Making this hotfix resolved all of my on-login lua errors stemming from this initial concat issue.

[Flamanis]

Just update. This has been fixed

On Wed, Jul 24, 2024, 2:57 PM Spencer @.***> wrote:

Just chiming in here, this issue ultimately stems from a failure to retrieve the spell details for Ebon Might in the custom spells lookup.

It seems like whenever it's being built, the spell customization table is unable to retrieve the spell info for ebon might. (Note: If you run this afterwards, it seems like the spell info is eventually made available. Perhaps the spell cache isn't fully loaded at first?)

Proposed temporary workaround:

Change line 248 in functions/spellcache.lua from

[395296] = {name = GetSpellInfo(395296) .. " (on your self)", icon = "Interface\Addons\Details\images\ebon_might"},

to

[395296] = {name = (GetSpellInfo(395296) or "none") .. " (on your self)", icon = "Interface\Addons\Details\images\ebon_might"},

Making this hotfix resolved all of my on-login lua errors stemming from this initial concat issue.

— Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/785#issuecomment-2248792877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL4J6ET72J6YSDIK3I5273ZOABJPAVCNFSM6AAAAABLMLLDVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYG44TEOBXG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[Flamanis]

Just chiming in here, this issue ultimately stems from a failure to retrieve the spell details for Ebon Might in the custom spells lookup.

It seems like whenever it's being built, the spell customization table is unable to retrieve the spell info for ebon might. (Note: If you run this afterwards, it seems like the spell info is eventually made available. Perhaps the spell cache isn't fully loaded at first?)

Proposed temporary workaround:

Change line 248 in functions/spellcache.lua from

[395296] = {name = GetSpellInfo(395296) .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

to

[395296] = {name = (GetSpellInfo(395296) or "none") .. " (on your self)", icon = "Interface\\Addons\\Details\\images\\ebon_might"},

Making this hotfix resolved all of my on-login lua errors stemming from this initial concat issue.

To explain whats actually going on: You have blizzard deprecation fallbacks enabled, which readds removed/soon to be removed functions. These were being used as if they were the new version of them, causing issues elsewhere. Newest releases fix this behavior

[spencerneutron]

@Flamanis

That's awesome! I'm not very familiar with this codebase yet, and I didn't realize that GetSpellInfo was a function coming from the addon/LibOpenRaid. I figured there was more going on than just some dysfunctional timing there.

Reading your PR #789 was helpful

[Flamanis]

It technically is not coming from libopenraid. It comes from blizzard, and TWW moved it to a new location/variable. They also changed the format of the information it gives back.

Blizzard added a cvar that loads the old functions (removed on tww launch)

LibOpenRaid was pulling the old and using it in place of the new