search

Tercioo / Details-Damage-Meter

Addon for World of Warcraft, does combat analyzes offering clean visual data for the player
Other
184 stars 135 forks source link

Brann Bronzebeard counting as pet #829

Open lebasp opened 2 months ago

lebasp commented 2 months ago

Brann Bronzebeard is counting only for the player who use Brann during the Session, if we change to "Everything" it separated from rest, but it screws the whole dps section.

Brann must not count as a pet for a single player, since it scres the meters comparing with others. And there's no option on Addon to put Brann on a filter to count as a Sixth player, instead of someone's else pet.

image

Flamanis commented 2 months ago

Try the most recent alpha version

lebasp commented 2 months ago

The alpha version was throwing me errors, couldn't test, reverted to release version

Flamanis commented 2 months ago

And the errors were?

On Tue, Sep 17, 2024, 6:55 AM Leandro Serafim @.***> wrote:

The alpha version was throwing me errors, couldn't test, reverted to release version

— Reply to this email directly, view it on GitHub https://github.com/Tercioo/Details-Damage-Meter/issues/829#issuecomment-2355498235, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL4J6EMJIJO7DLBY6CYUE3ZXAKDFAVCNFSM6AAAAABOIIISSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJVGQ4TQMRTGU . You are receiving this because you commented.Message ID: @.***>

amiyuy commented 2 months ago

I'm using version 13072.161 and Brann is still showing as a pet.

However I see the note in version 13066.161 - "Show Brann as a member of the group"

Is he supposed to show as a member of the group or pet?

hitboxr commented 2 months ago

I'm also using 13072.161 release and Brann is still showing as a pet for me as well, but only when delving solo. If I play a delve with other players in my party, Brann shows up listed separately as you'd expect. It seems like maybe https://github.com/Tercioo/Details-Damage-Meter/commit/e03bbc0d5f2068e93efdfc16d264d80a7b30b588 wasn't a complete fix and only works when in a party?

amiyuy commented 1 month ago

I'm also using 13072.161 release and Brann is still showing as a pet for me as well, but only when delving solo. If I play a delve with other players in my party, Brann shows up listed separately as you'd expect. It seems like maybe e03bbc0 wasn't a complete fix and only works when in a party?

I was in a 2 player delve when it wasn't working. It didn't work for my teammate in the 2 player one either, but did later in a larger group...

hitboxr commented 1 month ago

I was in a 2 player delve when it wasn't working. It didn't work for my teammate in the 2 player one either, but did later in a larger group...

And I did a solo delve today and saw Brann listed separately, then did another later and he was a pet again. Maybe it's spec-dependent? I did switch Brann from DPS to healer for Zekvir.