Tercioo / Details-Damage-Meter

Addon for World of Warcraft, does combat analyzes offering clean visual data for the player
Other
181 stars 132 forks source link

Items / Links in chat not clickable anymore #83

Open skupfer opened 4 years ago

skupfer commented 4 years ago

Game and Details! version Up2Date Retail and 8.3.0.7345.141 Use /details to grab these two.

Describe the bug If I right click a link / item, the bookmarks window will open Mouseover over an item won't show the tooltip anymore

Additional information: Embed in Chat Tab enabled Was working fine with DetailsRetail.8.3.0.7336.141 and prior

Tercioo commented 4 years ago

got it, thanks for reporting

------ Original Message ------ From: "skupfer" notifications@github.com To: "Tercioo/Details-Damage-Meter" Details-Damage-Meter@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: 29-Jun-20 5:45:33 PM Subject: [Tercioo/Details-Damage-Meter] Items / Links in chat not clickable anymore (#83)

Game and Details! version Up2Date and 8.3.0.7345.141 Use /details to grab these two.

Describe the bug If I right click a link / item, the bookmarks window will open Mouseover over an item won't show the tooltip anymore

Additional information: Embed in Chat Tab enabled Was working fine with DetailsRetail.8.3.0.7336.141 and prior — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTercioo%2FDetails-Damage-Meter%2Fissues%2F83&data=02%7C01%7C%7C7798fb37fedf42342fd008d81c6d5fc7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637290603364460462&sdata=MbRQ5rM16Vn1n9fJe9MC9Xdz8Byuvo6YGjAXOZ2OuPI%3D&reserved=0, or unsubscribe https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACEVKWA7GJKDK6RZ2VR3SRLRZD4O3ANCNFSM4OLSOUXQ&data=02%7C01%7C%7C7798fb37fedf42342fd008d81c6d5fc7%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637290603364470445&sdata=gHeybfm5Gm4nlVPXCTeUDtLnDauaC3KnHR0pgzIeKM4%3D&reserved=0.

Tercioo commented 4 years ago

DetailsRetail.8.3.0.7346.141 should fix an issue of hovering over bar don't show the tooltip. I think the right click on links is still a thing.

skupfer commented 4 years ago

Can confirm that both Right click / Hovering works again. Seems like its fixed (at least if you use elvui, too)

Not sure how I triggered this

1x Details\gumps\janela_principal.lua:5018: attempt to perform arithmetic on local 'alphaAmount' (a nil value)
[string "@Details\gumps\janela_principal.lua"]:5018: in function `SetWindowAlphaForCombat'
[string "@Details\core\parser.lua"]:5191: in function <Details\core\parser.lua:5184>
[string "=(tail call)"]: ?

Locals:
self = <table> {
 h_baixo = DetailsBottomSideBarHighlight1 {
 }
 menu_icons_size = 0.850000
 h_esquerda = DetailsLeftSideBarHighlight1 {
 }
 bg_r = 0.094118
 color_buttons = <table> {
 }
 toolbar_icon_file = "Details\images\toolbar_icons"
 modo = 2
 tooltip = <table> {
 }
 icons = <table> {
 }
 ponto3 = <table> {
 }
 ponto1 = <table> {
 }
 rolagem = false
 rows_max = 50
 windowBackgroundDisplay = Details_GumpFrame1 {
 }
 lastIcon = ENCOUNTERDETAILS_BUTTON {
 }
 menu_icons = <table> {
 }
 isMoving = false
 show_sidebars = false
 hide_icon = true
 consolidate = false
 toolbar_side = 1
 sub_atributo = 1
 atributo = 1
 bg_b = 0.094118
 need_rolagem = false
 backdrop_texture = "Details Ground"
 color = <table> {
 }
 hide_on_context = <table> {
 }
 barraS = <table> {
 }
 h_cima = DetailsTopSideBarHighlight1 {
 }
 switch_healer = false
 showing = <table> {
 }
 ponto4 = <table> {
 }
 __locked = true
 __snapH = false
 snap = <table> {
 }
 clickthrough_incombatonly = true
 hide_in_combat_alpha = 0
 firstIcon = DetailsClearSegmentsButton1 {
 }
 grab_on_top = false
 StatusBar = <table> {
 }
 verticalSnap = false
 hide_in_combat = false
 posicao = <table> {
 }
 row_height = 13.190489
 __pos = <table> {
 }
 show_statusbar = false
 clickthrough_window = false
 menu_anchor = <table> {
 }
 total_buttons_shown = 6
 hide_out_of_combat = false
 rows_created = 10
 bars_sort_direction = 1
 __was_opened = true
 switch_all_roles_in_combat = false
 clickthrough_toolbaricons = false
 clickthrough_rows = false
 barras = <table> {
 }
 horizontalSnap = false
 switch_tank = false
 windowSwitchButton = Details_SwitchButtonFrame1 {
 }
 switch_all_roles_after_wipe = false
 rowframe = DetailsRowFrame1 {
 }
 switch_damager = false
 auto_hide_menu = <table> {
 }
 window_scale = 1
 h_direita = DetailsRightSideBarHighlight1 {
 }
 meu_id = 1
 bg_g = 0.094118
 top = 196331.001113
 update = false
 last_interaction = 1593627654
 do_not_snap = false
 bars_inverted = false
 plugins_grow_direction = 1
 menu_alpha = <table> {
 }
 mostrando = "normal"
 ativa = true
 break_snap_button = DetailsBreakSnapButton1 {
 }
 alturaAntiga = 157.999985
 hide_in_combat_type = 1
 micro_displays_locked = true
 last_modo = 2
 segmento = 0
 skin = "Minimalistic"
 rows_showing = 1
 following = <table> {
 }
 skin_custom = ""
 ponto2 = <table> {
 }
 cached_bar_width = 465.166748
 oldwith = 465.166748
 LastModo = 2
 attribute_text = <table> {
 }
 iniciada = true
 micro_displays_side = 2
 StatusBarSaved = <table> {
 }
 __snapV = false
 v_barras = false
 instance_button_anchor = <table> {
 }
 version = 3
 scroll = Details_ScrollBar1 {
 }
 ignore_mass_showhide = false
 _version = <unnamed> {
 }
 desaturated_menu = false
 bgdisplay = Details_GumpFrame1 {
 }
 strata = "LOW"
 bgframe = Details_WindowFrame1 {
 }
 __snap = <table> {
 }
 row_info = <table> {
 }
 baseframe = DetailsBaseFrame1 {
 }
 freeze_texto = <unnamed> {
 }
 menu2_points = <table> {
 }
 libwindow = <table> {
 }
 statusbar_info = <table> {
 }
 menu_points = <table> {
 }
 menu_anchor_down = <table> {
 }
 stretch_button_side = 1
 largura_scroll = 26
 bgdisplay_loc = 0
 sub_atributo_last = <table> {
 }
 overall_data_warning = <unnamed> {
 }
 freeze_icon = <unnamed> {
 }
 auto_current = true
 floatingframe = DetailsInstance1BorderHolder {
 }
 switch_healer_in_combat = false
 rows_fit_in_window = 10
 switch_tank_in_combat = false
 bg_alpha = 0.183961
 menu_attribute_string = <table> {
 }
 isLocked = true
 wallpaper = <table> {
 }
 total_bar = <table> {
 }
 row_show_animation = <table> {
 }
 switch_damager_in_combat = false
 alert = DetailsAlertFrame1 {
 }
 bars_grow_direction = 1
}
entering_in_combat = true
true_hide = true
alphaAmount = nil
amount = nil
rowsamount = nil
menuamount = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'alphaAmount' (a nil value)"
_detalhes = <table> {
 SetBarSpecIconSettings = <function> defined @Details\gumps\janela_principal.lua:4290
 APITopics
Posese commented 4 years ago

Items appearing in chat cannot be clicked

With DetailsRetail.8.3.0.7348.141 I still get this issue, with Details embedded as a double window in Elvui right chat.

It doesn't happen immediately, and I haven't figured out exactly when it does, but after playing for a bit (hiding / unhiding the details window a few times), no links can be clicked anymore.

Tercioo commented 4 years ago

Just wait AddonSkins update and you'll be good.

------ Original Message ------ From: "Posese" notifications@github.com To: "Tercioo/Details-Damage-Meter" Details-Damage-Meter@noreply.github.com Cc: "Tercio Jose" terciob19@hotmail.com; "Comment" comment@noreply.github.com Sent: 11-Jul-20 7:31:35 PM Subject: Re: [Tercioo/Details-Damage-Meter] Items / Links in chat not clickable anymore (#83)

Items appearing in chat cannot be clicked

With DetailsRetail.8.3.0.7348.141 I still get this issue, with Details embedded as a double window in Elvui right chat.

It doesn't happen immediately, and I haven't figured out exactly when it does, but after playing for a bit (hiding / unhiding the details window a few times), no links can be clicked anymore.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTercioo%2FDetails-Damage-Meter%2Fissues%2F83%23issuecomment-657140155&data=02%7C01%7C%7Cbb15f90fe9f74dc36ac708d825ea2ca9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637301034980256328&sdata=OoU%2FaOeKfOvrfucfwW3wr5Xy1tDPZN7uSaczxBMQgsI%3D&reserved=0, or unsubscribe https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACEVKWBK5AEVI23RIND3NHLR3DR4PANCNFSM4OLSOUXQ&data=02%7C01%7C%7Cbb15f90fe9f74dc36ac708d825ea2ca9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637301034980266325&sdata=SwRDTbhn9m3Sk%2Fa46CTHeuw%2FPjkjOQKXF9BmfzZJvj4%3D&reserved=0.