Tercioo / Details-Damage-Meter

Addon for World of Warcraft, does combat analyzes offering clean visual data for the player
Other
184 stars 135 forks source link

"only one evoker, yonk bombardments ok" printout whenever combat starts with an Augmentation Evoker in group #862

Open Baeligg opened 2 weeks ago

Baeligg commented 2 weeks ago

Game and Details! version Retail, Details VTC 13819 release 11.0.5

Describe the bug

Lua Error Post here lua errors, if you aren't getting any, use /console scriptErrors 1 No LUA errors

Screenshots WoWScrnShot_110724_201121

Combat Log WoWCombatLog-110724_214756.txt

Other Information If necessary, add more info here.

pobiega commented 2 weeks ago

The printout is here: https://github.com/Tercioo/Details-Damage-Meter/blob/a7d118d44d48a49c9a1b895e6afcb01736f92355/core/parser.lua#L5772

Seems like a debug-printout that was accidentally left in.

raptormama commented 2 weeks ago

It does it with only one preservation evoker as well. I've seen this with both myself and a friend.

Commented out line 5772 and 5810 last night to disable the message, and am surprised this got pushed to release.

thefowles1 commented 2 weeks ago

It does it with any one evoker period. Did it while on my devoker in every instance without a second, and did it while on a non-evoker that had only one otherwise.

Maybe this will seem ignorant, but this hardly seems like something to be surprised about. Programming is a lot of work and even something simple as one singular character can make or break something. No biggie. In fact, the phrasing makes me chuckle. Yonk.

Tercioo commented 2 weeks ago

this is already fixed on latest alpha, correct?

------ Original Message ------ From "thefowles1" @.**@.>> To "Tercioo/Details-Damage-Meter" @.**@.>> Cc "Subscribed" @.**@.>> Date 08-Nov-24 7:13:42 PM Subject Re: [Tercioo/Details-Damage-Meter] "only one evoker, yonk bombardments ok" printout whenever combat starts with an Augmentation Evoker in group (Issue #862)

It does it with any one evoker period. Did it while on my devoker in every instance without a second, and did it while on a non-evoker that did not have another otherwise.

Maybe this will seem ignorant, but this hardly seems like something to be surprised about. Programming is a lot of work and one singular character can make or break something. No biggie. In fact, the phrasing makes me chuckle. Yonk.

— Reply to this email directly, view it on GitHubhttps://github.com/Tercioo/Details-Damage-Meter/issues/862#issuecomment-2465832436, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACEVKWHFSOK5MFPBEMQ5ACDZ7UZRNAVCNFSM6AAAAABRMTWVXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVHAZTENBTGY. You are receiving this because you are subscribed to this thread.Message ID: @.***>