search

Tercioo / Plater-Nameplates

Source code for World of Warcraft addon Plater Nameplates.
78 stars 42 forks source link

Personal Nameplate Anchoring #71

Closed Effeh closed 3 years ago

Effeh commented 3 years ago

Game and Plater version Plater-v9.0.1.310-Retail Game 9.0.1.36322

Describe the bug Frames anchored to the personal nameplate using WA2 and Plater shift on the Y axis sometimes on zone transition (and other events) and remain so until /reload (Or sometimes stubbornly until entire game reload). This happens with Plater, but never Kuinameplates - can't speak for other addons. I think this is also what was taking place in this issue: https://github.com/Tercioo/Plater-Nameplates/issues/26

I believe it's the frame WeakAurasAttachToPRD that's the culprit, but it only happens with the Plater personal nameplate.

Screenshots Here's how my personal resource display looks upon login: uponlogin

And this is what happens sometimes after hearthing, dying, or just progressing through a dungeon (randomly): afterawhile

When I /fstack, the WeakAurasAttachToPRD frame normally aligns to the top of the Plater PRD: fstackaligned

When the problem occurs, it winds up in the middle, and all attached objects drift accordingly: fstackmisaligned

Other Information My knowledge of lua is very poor, but my very uneducated guess is that this may be mostly the fault of WA2. There appears to be code regarding the PRD in Weakauras.lua that factors in Kui and Elvui nameplates but not Plater, perhaps leading to this behaviour.

However, these other nameplate addons also include their own invisible PRD anchor frame so that WA's anchor frame can be circumvented if needed. It would be greatly appreciated if such functionality was added to Plater so that the (likely) problematic WA2 code could be avoided completely.

Such as: https://github.com/kesava-wow/kuinameplates2/blob/master/Kui_Nameplates/plugins/personal-anchor.lua

cont1nuity commented 3 years ago

Adressed through https://github.com/WeakAuras/WeakAuras2/pull/2614

cont1nuity commented 3 years ago

PR has been closed. Next release of WA resolves this issue.