search

Tercioo / World-Quest-Tracker

Source code for the biggest world quest addon for World of Warcraft
22 stars 12 forks source link

No longer blocking LFG ad's #61

Open Rittler281 opened 1 year ago

Rittler281 commented 1 year ago

Addon was working perfectly for a very long time to block ads in the LFG but seems like since the latest update I am seeing a ton of carry ads in the LFG for m+ and raids with the block option enabled.

Edit: I have gone back to using the older version v9.2.5.438 because it still blocks ads from the group finder.

Archaiel commented 1 year ago

You can upgrade to v9.2.7. For now, you can re-enable the old behavior for LFG by editing WorldQuestTracker_GroupFinder.lua file in your Addons directory for WorldQuestTracker by:

  1. Search for function kspam.OnSortResults(results)
  2. Comment out the line that says if true then return end so it appears like this --if true then return end

The reasoning behind why this became a thing is that the previous filters stripped all groups that were > a certain amount of minutes (60, or overruled by your personal settings). This inadvertently removed real groups that were open longer (i.e. transmog groups, etc) and potentially unfairly affected real players.

It'd be good if the original behavior restored and this was filtered only for Mythic dungeon groups.