Tercioo / World-Quest-Tracker

Source code for the biggest world quest addon for World of Warcraft
22 stars 12 forks source link

LUA Error when "Group Finder" is active and entering combat #72

Open fubaWoW opened 1 year ago

fubaWoW commented 1 year ago

seems this function is no longer exists!

10x .../WorldQuestTracker/WorldQuestTracker_GroupFinder.lua:1123: attempt to call field 'GetActivityInfo' (a nil value)
[string "@WorldQuestTracker/WorldQuestTracker_GroupFinder.lua"]:1123: in function <.../WorldQuestTracker/WorldQuestTracker_GroupFinder.lua:1107>

C_LFGList API:

system LFGList (C_LFGList) 
   Functions 
      function C_LFGList.CanActiveEntryUseAutoAccept() 
      function C_LFGList.CanCreateQuestGroup(questID) 
      function C_LFGList.ClearApplicationTextFields() 
      function C_LFGList.ClearCreationTextFields() 
      function C_LFGList.ClearSearchTextFields() 
      function C_LFGList.CopyActiveEntryInfoToCreationFields() 
      function C_LFGList.DoesEntryTitleMatchPrebuiltTitle(activityID, groupID, optional playstyle) 
      function C_LFGList.GetActiveEntryInfo() 
      function C_LFGList.GetActivityFullName(activityID, optional questID, optional showWarmode) 
      function C_LFGList.GetActivityGroupInfo(groupID) 
      function C_LFGList.GetActivityInfoTable(activityID, optional questID, optional showWarmode) 
      function C_LFGList.GetApplicantDungeonScoreForListing(localID, applicantIndex, activityID) 
      function C_LFGList.GetApplicantInfo(applicantID) 
      function C_LFGList.GetApplicantPvpRatingInfoForListing(localID, applicantIndex, activityID) 
      function C_LFGList.GetFilteredSearchResults() 
      function C_LFGList.GetKeystoneForActivity(activityID) 
      function C_LFGList.GetLfgCategoryInfo(categoryID) 
      function C_LFGList.GetOwnedKeystoneActivityAndGroupAndLevel(optional getTimewalking) 
      function C_LFGList.GetPlaystyleString(playstyle, activityInfo) 
      function C_LFGList.GetSearchResultInfo(searchResultID) 
      function C_LFGList.GetSearchResults() 
      function C_LFGList.HasActiveEntryInfo() 
      function C_LFGList.HasSearchResultInfo(searchResultID) 
      function C_LFGList.IsPlayerAuthenticatedForLFG(optional activityID) 
      function C_LFGList.Search(categoryID, optional filter, optional preferredFilters, optional languageFilter, optional searchCrossFactionListings) 
      function C_LFGList.SetEntryTitle(activityID, groupID, optional playstyle) 
      function C_LFGList.SetSearchToActivity(activityID) 
      function C_LFGList.SetSearchToQuestID(questID) 
      function C_LFGList.ValidateRequiredDungeonScore(dungeonScore) 
      function C_LFGList.ValidateRequiredPvpRatingForActivity(activityID, rating) 
   Events 
      event Event.LFGList.LfgGroupDelistedLeadershipChange -> listingName, automaticDelistTimeRemaining 
      event Event.LFGList.LfgListActiveEntryUpdate -> optional created 
      event Event.LFGList.LfgListApplicantListUpdated -> optional newPendingEntry, optional newPendingEntryWithData 
      event Event.LFGList.LfgListApplicantUpdated -> applicantID 
      event Event.LFGList.LfgListApplicationStatusUpdated -> searchResultID, newStatus, oldStatus, groupName 
      event Event.LFGList.LfgListAvailabilityUpdate ->  
      event Event.LFGList.LfgListEntryCreationFailed ->  
      event Event.LFGList.LfgListEntryExpiredTimeout ->  
      event Event.LFGList.LfgListEntryExpiredTooManyPlayers ->  
      event Event.LFGList.LfgListJoinedGroup -> searchResultID, groupName 
      event Event.LFGList.LfgListSearchFailed -> optional reason 
      event Event.LFGList.LfgListSearchResultUpdated -> searchResultID 
      event Event.LFGList.LfgListSearchResultsReceived ->  
   Tables 
      enumeration Enum.LFGEntryPlaystyle 
      enumeration Enum.LFGListDisplayType 
      structure BestDungeonScoreMapInfo 
      structure GroupFinderActivityInfo 
      structure LfgApplicantData 
      structure LfgCategoryData 
      structure LfgEntryData 
      structure LfgSearchResultData 
      structure PvpRatingInfo 
      structure WowLocale

also /dump type(C_LFGList.GetActivityInfo) returns "nil"

mikemaring commented 1 year ago

Seeing the same

`Message: .../WorldQuestTracker/WorldQuestTracker_GroupFinder.lua:1123: attempt to call field 'GetActivityInfo' (a nil value)
Time: Sun Dec 25 02:41:04 2022
Count: 2
Stack: .../WorldQuestTracker/WorldQuestTracker_GroupFinder.lua:1123: attempt to call field 'GetActivityInfo' (a nil value)
[string "=[tsm error check]"]:1: in main chunk
[string "=(tail call)"]: ?
[string "=[C]"]: in function `GetActivityInfo'
[string "@Interface/AddOns/WorldQuestTracker/WorldQuestTracker_GroupFinder.lua"]:1123: in function <.../WorldQuestTracker/WorldQuestTracker_GroupFinder.lua:1107>`
yoshimo commented 1 year ago

https://wowpedia.fandom.com/wiki/API_C_LFGList.GetActivityInfo says the replacement is C_LFGList.GetActivityInfoTable

FALL1N1 commented 1 year ago

should be fixed with https://github.com/Tercioo/World-Quest-Tracker/commit/31571da4cae0a0c8e2760a9bfcb1e21ffa59603d

fubaWoW commented 1 year ago

should be fixed with 31571da

ok thanks, will test it later :)