search

Tereneckla / wotlk

wotlk simulations
MIT License
0 stars 2 forks source link

Essence of the Martyr and Icon of the Silver Crescent have no shared cooldown #35

Closed Icebeam666 closed 1 year ago

Icebeam666 commented 1 year ago

Describe the bug Essence of the Martyr on-use effect and Icon of the Silver Crescent on-use effect are being used at the same time. So there is no cooldown after using the first trinket to when you can use the other tinket.

To Reproduce Steps to reproduce the behavior:

  1. Create a character to sim
  2. Equip Essence of the Martyr and Icon of the Silver Crescent
  3. Run simulation
  4. Go to Log and see the time at which the trinkets are being used

Expected behavior After you use one of the trinkets, the other one should be available to use 20 seconds after (thats how it works on chromie at least). Seeing as the on-use effect lasts 20 seconds, you can use the second trinket right as the first one falls off. But you should not be able to use both at the same time.

Sim Links and Screenshots Notice the timestamps image image

Additional context I do not know if this applies to all trinkets on the website or just these two.

Tereneckla commented 1 year ago

Also caused by copy paste of tbc implementation