Tereneckla / wotlk

wotlk simulations
MIT License
0 stars 2 forks source link

[Hunter] Sim uses level 80 hunter pets spells #40

Closed hofik19 closed 1 year ago

hofik19 commented 1 year ago

Describe the bug When checking simulation results it shows lvl 80 abilities beeing used for pet

To Reproduce Steps to reproduce the behavior:

  1. Go to results after running a hunter sim
  2. Hower over pet skill eg. "Bite"
  3. See it showing level 80 version of abillity

Expected behavior It should use max level 70 abilities

Sim Links and Screenshots image [https://tereneckla.github.io/wotlk/hunter/#eJy9U0FoE0EU3T+brJtNxbFZmjUITSNCEIXZxODGgzP2VA9qURC8taCCpYpUL/Zm6cmDR2lyEXIRD4KgQktoUdAYizElhVRtQdsakCJx20MrxYKzOyEoIhJY+5gHf/78//6bZUeTuqV2KTKpjIDSO9h/8+KQGsAocgdpITy3CUY+HFMW6pDZAnLV8mkqflkTUQhn3oPxlB+v12EhD+S6JWtBXKiBYSO3ogN/KoJR02MBfiwWGeJFGC/y/ERbTN5oZEK4UgVjVOej8rDR0ML4YxHcjNN4jWc6cKEOxovwr4LOoCB++xmMRb3hsLYG5AovV/HWKpABNxqZFxIqftX0X+D+V/TmBOH/+bKTJBdc2fv8MvMhctnyxdpULarEFRKyUB/kUAlpY0jaFhxj2zPHO7STVjuGpaM3NNoDcbTb3bN7rHuvhlQ/5w7OAKfKqXHKnGBmMw4maDrpYpb2QsRUZdwZCasIA5N75DFAjwCegVwEeAfQJUbZNF164+ArjcNt6EyZCUISxEyRlGkmEoeTJiGppJlMmYecYAl09W4Z4VwZRecqKD5dQaRaQV8AbPBnQfoAUhZJsWUUEPKnmLiBpLM9wuNrmhaZGdp1yUWVJh6j6AnDf+A//0P2LeaJjjXujU4LEN9s8hs7LvbfaR+c+e3VzZbGz/fbvqaznT8erFZOrlFv5tv0YCa4b3oQsSX/wxl2dpOWz00dOT280qK+7ZGff+PPV4dHc0+mdu1nf+v4CQH0uuM=]

Desktop (please complete the following information):

Additional context Whole pet calculations might be wrong and probably uses level 80 pet stats and skills. Pet DMG seems to be a lot higher than it should. I can provide proper values and skill links, just let me know what is needed.

hofik19 commented 1 year ago

image Another wrong spellit should use Rank 5 https://www.wowhead.com/wotlk/spell=64494/furious-howl

Tereneckla commented 1 year ago

It's visual, I only edited the values of the abilities

hofik19 commented 1 year ago

Ok, I understand, but I still want to do some more tests for pet dmg calculation. Are those stats, visible in the log, are the pet stats before fight starts? I see them beeing changed dynamically when buffs kicks in image

hofik19 commented 1 year ago

There is a big difference in Bite DMG between server and sim. Server results looks more accurate Test/sim was made without talents/buffs/debuffs. Only gear. image

Sorry for messing with issue on git hub, I'm not good at it :D

Tereneckla commented 1 year ago

Oh yeah, missed the focus dump abilities in the sim Only did all the other pet abilities

Tereneckla commented 1 year ago

Fixed the damage

hofik19 commented 1 year ago

How about the Pet stats in log? Cos if the stats in log are showing used values than there could be another issue with them beeing too high. Character stats are correct on both server and sim, but pet have much more Strength and AP, (Agi is also weird but not by much) image No talents/buffs/debuffs, only bow cos it won't sim without a weapon.

I can open another issue if necessery

Tereneckla commented 1 year ago

Done as well

hofik19 commented 1 year ago

Thank you! Now it looks more accurate: Pre-Raid BiS before fixes: image and after: image

I will do some more comparisons to be sure that there is nothing left to be adjusted ;)