search

TeresaRachelTalim / RShiny_Assignment

0 stars 0 forks source link

R Shiny assessment feedback #2

Open minqigai opened 3 months ago

minqigai commented 3 months ago

Hi @TeresaRachelTalim, thanks for attempting the shiny assessment, please find my feedbacks below:

  1. The interface fully fulfilled all requirements. The user can input loss data and tail factor. The app can correctly calculate the reserve using the chain ladder method and visualise the result. Well done!

  2. The UI design is very comfortable to look at.

  3. You included a guide to help the user in preparing the sample data. This is a good point to ensure people know how to use the app. image

  4. It is very nice to put comments inside, which makes the code easy to read. https://github.com/TeresaRachelTalim/RShiny_Assignment/blob/332ab1940e0f013f546835d67929dcd3c5d21fc0/app.R#L19

  5. The calculation logic is concise. The coding is dynamic, which can cater for different numbers of loss years and development years. Good job!

jonekeat commented 3 months ago

@TeresaRachelTalim good work! Please find my feedback below:

  1. In UI, for static elements like instructions text & image, since it is not going to update for entire app lifespan, so we should put it in UI instead of using output components https://github.com/TeresaRachelTalim/RShiny_Assignment/blob/332ab1940e0f013f546835d67929dcd3c5d21fc0/app.R#L33-L34

  2. For tail factor, we can specify a step parameter to control how large the number increase/decrease, usually 0.1 is enough, default of 1 is too large https://github.com/TeresaRachelTalim/RShiny_Assignment/blob/332ab1940e0f013f546835d67929dcd3c5d21fc0/app.R#L39

  3. The plotOutput and download button UI can be wrapped in a single uiOutput, since both require file input https://github.com/TeresaRachelTalim/RShiny_Assignment/blob/332ab1940e0f013f546835d67929dcd3c5d21fc0/app.R#L43-L44

  4. The download button is a very nice feature!