CommitLog / Memtable flush: do not delete commit logs with unused entries - Githubissues

Terkwood / AugustDB

Key/value store backed by LSM Tree architecture.

MIT License

8 stars 1 forks source link

CommitLog / Memtable flush: do not delete commit logs with unused entries #104

Closed Terkwood closed 3 years ago

Terkwood commented 3 years ago

In the case where we are replaying commit logs with a lot of entries, we don't want to delete the commit log in Memtable.flush ~line 41

We should use a second file for the replay mode, one that isn't deleted while being read.

tasks

double check that this is happening, read line probably locks the file so it can't be deleted
if that's the case, clean up the code so it's more clear what's going on