search

TerminalFi / LSP-copilot

GitHub Copilot support for Sublime Text LSP plugin provided through Copilot.vim.
623 stars 25 forks source link

In "panel completion", `Mean Probability` seems to be always `0` #154

Closed jfcherng closed 2 weeks ago

jfcherng commented 1 month ago

Originally asked in https://discord.com/channels/280102180189634562/645268178397560865/1241115323550142536.

That is, https://github.com/TerminalFi/LSP-copilot/blob/90b9176a7c22feb3dec75465c606aa4022cd1194/plugin/ui/panel_completion.py#L264C17-L264C21 image

The code is good but in the server payload it just says 0s. So I guess that Mean Probability only provides confusion now? But at the same time, we don't know those 0s are intentional or what.

Let's remove them from headers?

timfjord commented 1 month ago

If it is always 0, hiding it makes sense. But has it been always like that? Maybe we are missing something in how we call the API

jfcherng commented 1 month ago

If it is always 0, hiding it makes sense. But has it been always like that? Maybe we are missing something in how we call the API

pretty sure it has other value back to when we implemented it. never saw 0 at that time.

timfjord commented 1 month ago

Hmm, then they probably changed something along the way.

jfcherng commented 1 month ago

This was it https://github.com/TerminalFi/LSP-copilot/pull/18#issuecomment-1193094714

TerminalFi commented 2 weeks ago

Fixed / Removed in #167