fix: sign out command doesn't work

TerminalFi / LSP-copilot

GitHub Copilot support for Sublime Text LSP plugin provided through Copilot.vim.

623 stars 25 forks source link

fix: sign out command doesn't work #157

Closed jfcherng closed 1 month ago

jfcherng commented 1 month ago

Fixes https://github.com/TerminalFi/LSP-copilot/issues/156

TerminalFi commented 1 month ago

Before merging, I'd like to look into this a bit.

TerminalFi commented 1 month ago

@jfcherng This is odd, but the command works for me on MacOS?

jfcherng commented 1 month ago

@jfcherng This is odd, but the command works for me on MacOS?

Even after re-sign in, can you sign out again?

jfcherng commented 1 month ago

Some observations,

previously, copilot's session file is hosts.json but now (since when?) it's apps.json.
my first sign out success (I believe at that moment it uses hosts.json)
I re-sign in. After that, I failed to sign out. (now it uses apps.json)

I don't know whether the session file change matters or not.

TerminalFi commented 1 month ago

Mine just switched over to apps.json and now signout is not working. Let me dig some more. I would image, it is the agent.js that is failing here. Since it should be the one handling the actual signout logic

jfcherng commented 1 month ago

Mine just switched over to apps.json and now signout is not working. Let me dig some more. I would image, it is the agent.js that is failing here. Since it should be the one handling the actual signout logic

Yes, it's weird that Copilot.vim seems just calls the signOut command and that's all. github/copilot.vim@c79d711/autoload/copilot.vim#L630-L638

But since Copilot.vim intentionally disables the issue page on GitHub, I guess my report may not be seen by staff in Copilot's general discussion.