refactor: use Jinja2 for completion popup / panel completion

[jfcherng]

This makes logics more clear.

[timfjord]

@jfcherng I was going to extract the phantom stuff to the templates but wasn't sure about the template extension. You used the .md extension in the templates (e.g. completion@popup.md.jinja) but technically it is .html. What if I rename *.md.jinja to *.html.jinja

[jfcherng]

completion@popup.md.jinja) but technically it is .html

No, it's Markdown. And at the same time, Markdown is a superset of HTML.

• https://github.com/TerminalFi/LSP-copilot/blob/dcbd65de368b6535ef3bc1cf86ea24fe58e0a2a7/plugin/ui/completion.py#L241
• and we do use Markdown feature: fenced code block https://github.com/TerminalFi/LSP-copilot/blob/dcbd65de368b6535ef3bc1cf86ea24fe58e0a2a7/plugin/templates/completion%40popup.md.jinja#L91-L93

---

What if I rename .md.jinja to .html.jinja

No functionality will be changed. But ST will use HTML (Jinja) for syntax highlighting when editing the template file and thus no markdown grammar will be highlighted.

---

Btw, Jinja2 syntax highlighting: https://packagecontrol.io/packages/Jinja2

[timfjord]

Ok, thanks for the clarification. Will stick to the .md then