search

TerminalFi / LSP-copilot

GitHub Copilot support for Sublime Text LSP plugin provided through Copilot.vim.
625 stars 25 forks source link

refactor: remove deprecated method #69

Closed jfcherng closed 1 year ago

jfcherng commented 1 year ago

It has been more than a month since last lsp_utils release so I guess it's safe to remove deprecated minimum_node_version (it has been replaced by required_node_version).

jfcherng commented 1 year ago

The test fail from flake8 looks like a false positive to me. They are used with # type: .... But sure, technically it's "unused" in grammatic view...

Okay. This is embarrassing as latest flake8 v6 uses pyflakes v3 and pyflakes v3 requires python>=3.6 so they ask user to use annotation now. https://github.com/PyCQA/pyflakes/issues/747

I think we have to pin a previous flake8 now unless we use python 3.8 in the future.