search

TerminalMC / ChatNotify

A client-side multi-loader Minecraft mod that allows the user to set up audio and visual notifications for chat messages.
https://modrinth.com/mod/Iudurxl8
Apache License 2.0
2 stars 1 forks source link

Fast spam of sounds when joing with chat history mod #4

Closed Xsogon closed 3 months ago

Xsogon commented 3 months ago

When joining a world while using any kind of chat history mod, any previous mentions of your name will cause the notify sound, this causes a fast spam of the sound as the old messages load.

Maybe if it was disabled for old/preloaded messages or if there was a few second delay until the chat is registered would help.

Thanks you

NotRyken commented 3 months ago

Please specify your Minecraft loader, Minecraft version, ChatNotify version, and all versions of all chat history mods for which you have confirmed that this is an issue.

Xsogon commented 3 months ago

Minecraft loader: fabric-loader-0.15.11-1.20.6 Minecraft version: 1.20.6 ChatNotify version: ChatNotify-Fabric-1.20.6-1.3.0 Chat History Mod: chatpatches-206.6.5

Video of the notify spam happening: https://youtu.be/ZhRDUem7ztQ?si=Pt0K4CozXKGsSm87

Seems to always happen when I load into a world/server for the first time after loading up the game and then will happen less frequently after exiting and joining a different world/server.

I also included the setting I have for ChatPatches and ChatNotify incase it could be something to do with that. Hope this helps

NotRyken commented 3 months ago

Thanks for the details, though I'm curious why you say it "will happen less frequently after exiting and joining a different world/server". According to your video and my own testing it only happens on the first game join after launching the game.

Aside from that, the reason for this is that ChatNotify's default message capture point is the method used by ChatPatches' chat log system. By switching ChatNotify's global option "Early Mixin" to ON, you can prevent ChatNotify from detecting the messages added by ChatPatches.

This solution should apply to all chat history mods, but it ultimately depends on which method they call when restoring history.

Xsogon commented 3 months ago

This works perfect, about the other thing I am probably just misremembering from using the two mods together for so long.

Thanks for your help!

NotRyken commented 3 months ago

v1.3.1 fixes this by adding an option to automatically switch to early mixin when ChatPatches is installed.