Closed Lillecarl closed 7 years ago
Please dont publish unfinished work. Also the same applies to the WinBox plugin, include in default set of plugins?
I'll close this until more time has been put into it. This should probably be implemented after https://github.com/Terminals-Origin/Terminals/issues/111 is fixed to not cause TeamViewer weirdo crashes.
We should also read the registry to see that the TeamViewer settings are configured to work with Terminals integration (Tabbed teamviewer sessions must be off)
I'd be glad to have TeamViewer inside this tool
Work in progress, thought I'd open a PR to see if there's any interest in having this at all, considering TeamViewer has their own "collection" for this.
The reasoning behind this is that you might want to have servers categorized in the same place, which is Terminals ofc ;)
It's a bit rough on the edges, for example if Terminals crashes or exits abnormally it'll bring TeamViewer down with it.
It's also not a 100% attachment rate atm, if the computer is in your TeamViewer contacts, because then the attachment function might not be fast enough to find the TeamViewer window during the brief moment it's still got the ID in the title. This can be worked around either by adding a TeamViewer configuration page with "ContactName" to search for, or by adding the ID into the name of the contact in TeamViewer.
Do you guys think this is a relevant feature to implement? For me this makes Terminals handle all server connections i use at work :)
Note that this is still WIP, shouldn't search through all open windows on the entire computer using stackoverflow code etc... :)