Terminals is a secure, multi tab terminal services/remote desktop client. It uses Terminal Services ActiveX Client (mstscax.dll). The project started from the need of controlling multiple connections simultaneously. It is a complete replacement for the mstsc.exe (Terminal Services) client. This is official source moved from Codeplex.
Other
1.26k
stars
234
forks
source link
"Next" button in first run wizard does not check if a master password is entered when the "Enable Master Password" checkbox is ticked #66
In the first run wizard, on Master Password page, by default, the checkbox that reads "Enable Master Password" is enabled. when i click the Next button without entering a master password in the text fields, it proceeds right away to the next page without performing a check if the password was even entered or not. the desired output was a error or warning message box telling me that some of the required text fields are missing. analyzed part of the code under "FirstRunWizard.cs" file from line 59.
else if (SelectedForm == WizardForms.MasterPassword) { if (mp.StorePassword) { SwitchToDefaultCredentials(); } else { SwitchToOptions(); } }
there must be a missing a bool check. i could do a new PR. but i'm busy. please fix this. thanks 👍
In the first run wizard, on Master Password page, by default, the checkbox that reads "Enable Master Password" is enabled. when i click the Next button without entering a master password in the text fields, it proceeds right away to the next page without performing a check if the password was even entered or not. the desired output was a error or warning message box telling me that some of the required text fields are missing. analyzed part of the code under "FirstRunWizard.cs" file from line 59.
else if (SelectedForm == WizardForms.MasterPassword) { if (mp.StorePassword) { SwitchToDefaultCredentials(); } else { SwitchToOptions(); } }there must be a missing a bool check. i could do a new PR. but i'm busy. please fix this. thanks 👍