search

Terminals-Origin / Terminals

Terminals is a secure, multi tab terminal services/remote desktop client. It uses Terminal Services ActiveX Client (mstscax.dll). The project started from the need of controlling multiple connections simultaneously. It is a complete replacement for the mstsc.exe (Terminal Services) client. This is official source moved from Codeplex.
Other
1.25k stars 235 forks source link

Implement filling Webforms in HTTP/HTTPS plugin #95

Closed Lillecarl closed 2 months ago

Lillecarl commented 7 years ago

Support for filling forms in HTTP and HTTPS plugins

jirkapok commented 7 years ago

Please add missing unit tests, fix WebProtocols_CreateControls_ReturnsEmpty test.

Lillecarl commented 7 years ago

Considering i don't know how to run the tests, i hope this is what you're looking for :)

jirkapok commented 7 years ago

Still two tests are failing. I am going to have a look my self. So we can merge it.

jirkapok commented 7 years ago

To fix the tests:

Lillecarl commented 7 years ago

Updated to try and fit your comments. It might still not be perfect for your style though. We'll see :)

jirkapok commented 7 years ago

Please add missing tests to cover what is not automatically tested. Otherwise i will fix the issues you dint comment.

Lillecarl commented 7 years ago

If there's anything you want fixed, feel free to push to my branch too, you should have write access to the pullrequested branches :)

My reasoning behind instancing the icon twice and moving the https port definition is only to keep consistency within the codebase.

Hope to see this if not merged, implemented :) It's a killer feature! :)

Lillecarl commented 7 years ago

If you want, we can rebase this branch on master and rewrite the history too :) Contributed to a project awhile ago where a pretty gitlog was important.

Lillecarl commented 7 years ago

How are we doing on this? I'm not sure which changes i've missed, please rereview this.

jirkapok commented 7 years ago

Go through all comments for each file, mainly:

Lillecarl commented 6 years ago

@jirkapok It's the wrong way around, but i'd love it if you helped me cleanup the last bits as you'd like them. I think by GitHub design you've got write access to the pullrequest branch.

The tests i think i implemented, i'm not sure what's missing. And upgrades i know not how to do.

Best Regards Carl :)

jirkapok commented 1 year ago

Based on project resurection, i will cherry pick these changes and implement them in 46-putty branch.

Lillecarl commented 1 year ago

I'm glad to hear, I don't have any Windows machines anymore so I can't assist, but I suspekt you've got this 😄